Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(override): failed to override finalizers #338

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

JackZxj
Copy link
Collaborator

@JackZxj JackZxj commented Sep 18, 2024

see: #328

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.91%. Comparing base (f16c725) to head (cb49360).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/override/util.go 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   33.94%   33.91%   -0.03%     
==========================================
  Files         156      156              
  Lines       14723    14730       +7     
==========================================
- Hits         4997     4995       -2     
- Misses       9204     9214      +10     
+ Partials      522      521       -1     
Flag Coverage Δ
unittests 33.91% <87.50%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackZxj JackZxj force-pushed the fix/override-finalizers-2 branch 2 times, most recently from 5f55104 to 9bcaf78 Compare September 18, 2024 13:42
@qclc
Copy link
Collaborator

qclc commented Sep 19, 2024

/lgtm

@qclc qclc self-requested a review September 19, 2024 03:09
Copy link
Collaborator

@qclc qclc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@mrlihanbo mrlihanbo self-requested a review September 19, 2024 06:14
@JackZxj JackZxj merged commit ab06029 into kubewharf:main Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants