fix(sysadvisor): get util based headroom per-numa #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funnydreamwinz
force-pushed
the
dev/fix-util-based-headroom
branch
from
ccf04e5 to
50b426d
Compare
funnydreamwinz
force-pushed
the
dev/fix-util-based-headroom
branch
3 times, most recently
from
fd8aa40 to
3383b49
Compare
luomingmeng
reviewed
Jan 25, 2025
| @@ -40,11 +41,8 @@ const ( | |||
|
|
|||
| func (ha *HeadroomAssemblerCommon) getUtilBasedHeadroom(options helper.UtilBasedCapacityOptions, | |||
There was a problem hiding this comment.
add a input parameter numaList []int, such as:
func (ha *HeadroomAssemblerCommon) getUtilBasedHeadroom(options helper.UtilBasedCapacityOptions,
reclaimMetrics *metaserverHelper.ReclaimMetrics,
lastReclaimedCPUPerNuma map[int]float64,
numaList []int,
)
| @@ -54,10 +52,14 @@ func (ha *HeadroomAssemblerCommon) getUtilBasedHeadroom(options helper.UtilBased | |||
| } | |||
|
|
|||
| util := reclaimMetrics.CgroupCPUUsage / reclaimMetrics.ReclaimedCoresSupply | |||
| lastReclaimedCPU := 0.0 | |||
There was a problem hiding this comment.
sum the lastReclaimedCPU by numaList, such as:
for _, numaID := range numaList {
lastReclaimedCPU += lastReclaimedCPUPerNuma[numaID]
}
| headroom, err := ha.getUtilBasedHeadroom(options, reclaimMetrics) | ||
| lastReclaimedCPUPerNuma := make(map[int]float64) | ||
| lastReclaimedCPUPerNuma[numaID] = reclaimedCPUs[numaID] | ||
| headroom, err := ha.getUtilBasedHeadroom(options, reclaimMetrics, lastReclaimedCPUPerNuma) |
There was a problem hiding this comment.
only input the numaID as list and all numa reclaimed CPUs reclaimedCPUs
headroom, err := ha.getUtilBasedHeadroom(options, reclaimMetrics, reclaimedCPUs,[]int{numaID})
| @@ -201,7 +211,7 @@ func (ha *HeadroomAssemblerCommon) getHeadroomByUtil() (resource.Quantity, map[i | |||
| } | |||
|
|
|||
| options.MaxCapacity *= float64(len(nonBindingNumas)) | |||
| headroom, err := ha.getUtilBasedHeadroom(options, reclaimMetrics) | |||
| headroom, err := ha.getUtilBasedHeadroom(options, reclaimMetrics, lastReclaimedCPUPerNuma) | |||
There was a problem hiding this comment.
here only need use nonBindingNumas:
headroom, err := ha.getUtilBasedHeadroom(options, reclaimMetrics, reclaimedCPUs, nonBindingNumas)
3383b49 to
cf0a6cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: