Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qrm): fix numaBindingHintHandler calculateHints before GetHintsFr… #765

Conversation

luomingmeng
Copy link
Collaborator

…omExtraStateFile

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.54%. Comparing base (0c24ce6) to head (5554c77).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   60.69%   60.54%   -0.16%     
==========================================
  Files         603      603              
  Lines       63212    63213       +1     
==========================================
- Hits        38367    38272      -95     
- Misses      21002    21101      +99     
+ Partials     3843     3840       -3     
Flag Coverage Δ
unittest 60.54% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xu282934741 xu282934741 merged commit fe23afb into kubewharf:main Jan 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants