Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sysadvisor): fix assembler calculate reclaim pool size of non-bin… #762

Merged

Conversation

luomingmeng
Copy link
Collaborator

…ding NUMAs when the requirements of shared pools are larger than their pool size

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng requested a review from gary-lgy as a code owner January 14, 2025 03:37
@luomingmeng luomingmeng force-pushed the dev/fix-sysadvisor-assembler branch 2 times, most recently from 9219610 to 5e5c1fd Compare January 14, 2025 03:52
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.66%. Comparing base (0c24ce6) to head (f6e91c3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...u/assembler/provisionassembler/assembler_common.go 41.66% 6 Missing and 1 partial ⚠️
...sor/plugin/qosaware/resource/cpu/advisor_helper.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   60.69%   60.66%   -0.04%     
==========================================
  Files         603      603              
  Lines       63212    63221       +9     
==========================================
- Hits        38367    38352      -15     
- Misses      21002    21019      +17     
- Partials     3843     3850       +7     
Flag Coverage Δ
unittest 60.66% <56.52%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ding NUMAs when the requirements of shared pools are larger than their pool size
@luomingmeng luomingmeng force-pushed the dev/fix-sysadvisor-assembler branch from 5e5c1fd to f6e91c3 Compare January 20, 2025 04:29
@xu282934741 xu282934741 merged commit acec869 into kubewharf:main Jan 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants