Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: not update k8s.io/apimachinery #1202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dominikholler
Copy link
Contributor

The new upcomming version of k8s.io/apimachinery would enforce an update of the golang version. So let's delay updating the dependency until we want to pick up golang 1.23 .

What this PR does / why we need it:

With the config proposed in this PR, a local run of renovate resulted in
dominikholler@3475137#diff-ba0784a950902285760f839a4ad720a381b2981e8a67147f5f43f7508e6343ed
which looks quite good. I have the suspicion, that a full update of k8s.io/apimachinery enforces golang 1.23, which might confuse renovate.

Which issue(s) this PR fixes:

I hope it fixes #1109 , even I could not the reproduce specific the issue

Special notes for your reviewer:

Release note:

NONE

The new upcomming version of k8s.io/apimachinery would enforce an
update of the golang version. So let's delay updating the
dependency until we want to pick up golang 1.23 .

Signed-off-by: Dominik Holler <[email protected]>
@kubevirt-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 10, 2025
@kubevirt-bot kubevirt-bot requested a review from akrejcir January 10, 2025 16:33
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akrejcir for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot requested a review from ksimon1 January 10, 2025 16:33
@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Jan 10, 2025
@dominikholler
Copy link
Contributor Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants