Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use the template architecture label #1201

Merged
merged 1 commit into from
Jan 15, 2025
Merged

refactor: use the template architecture label #1201

merged 1 commit into from
Jan 15, 2025

Conversation

nestoracunablanco
Copy link
Contributor

@nestoracunablanco nestoracunablanco commented Jan 10, 2025 •
edited
Loading

This change simplifies the parsing process by reducing complexity.

Release note:

NONE

refactor: use the template architecture label
ca7357e 
This change simplifies the parsing process by reducing complexity.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nestoracunablanco
Copy link
Contributor Author

@jcanocan @lyarwood what do you think about this PR?

lyarwood
lyarwood approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @akrejcir

@kubevirt-bot kubevirt-bot requested a review from akrejcir January 15, 2025 10:23
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@akrejcir
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akrejcir
Copy link
Collaborator

akrejcir commented Jan 15, 2025 •
edited
Loading

Looks good.
Please remove unnecessary text from the PR's description.

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@kubevirt-bot kubevirt-bot merged commit 9403b6c into kubevirt:main Jan 15, 2025
12 checks passed
@nestoracunablanco nestoracunablanco deleted the refactor/templateArchWithLabel branch January 15, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyarwood lyarwood lyarwood approved these changes

@jcanocan jcanocan Awaiting requested review from jcanocan

@akrejcir akrejcir Awaiting requested review from akrejcir

Assignees

@lyarwood lyarwood

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nestoracunablanco @akrejcir @kubevirt-bot @lyarwood