fix(prow-manifests): force .yaml suffix instead of .yml#5035
Conversation
Prow autobump tool considers only YAML files which have `.yaml` suffix and ignore files ending with `.yml`. => https://github.com/kubernetes-sigs/prow/blob/b4c09133/cmd/generic-autobumper/main.go#L367-L372 Signed-off-by: Denis Ollier <dollierp@redhat.com>
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Prow component images to version v20260502-b4c09133a and standardizes manifest file extensions from .yml to .yaml across the deployment configuration and synchronization scripts. Feedback was provided to ensure that the cleanup process in the sync script continues to remove legacy .yml files to prevent stale manifests from persisting during the transition.
|
|
||
| # Cleanup previous manifests | ||
| rm -f *.yml *.yaml | ||
| rm -f *.yaml |
There was a problem hiding this comment.
The cleanup command was modified to only remove *.yaml files. During the transition from .yml to .yaml, it is important to continue removing *.yml files to ensure that stale manifests are not left in the directory. Leaving them behind could lead to confusion or accidental inclusion of deprecated files in the repository.
| rm -f *.yaml | |
| rm -f *.yml *.yaml |
2 participants
What this PR does / why we need it:
Prow autobump tool considers only YAML files which have
.yamlsuffix and ignore files ending with.yml.=> https://github.com/kubernetes-sigs/prow/blob/b4c09133/cmd/generic-autobumper/main.go#L367-L372
Special notes for your reviewer:
/cc @dhiller