Skip to content

ci: Ubuntu s390x functest common-instacetypes job#4959

Open
nestoracunablanco wants to merge 1 commit into
kubevirt:mainfrom
nestoracunablanco:ci/commonInstaceTypesUbuntus390x
Open

ci: Ubuntu s390x functest common-instacetypes job#4959
nestoracunablanco wants to merge 1 commit into
kubevirt:mainfrom
nestoracunablanco:ci/commonInstaceTypesUbuntus390x

Conversation

@nestoracunablanco
Copy link
Copy Markdown
Contributor

Release note:

NONE

Signed-off-by: Nestor Acuna Blanco <nestor.acuna@ibm.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 15, 2026
@kubevirt-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lyarwood for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nestoracunablanco
Copy link
Copy Markdown
Contributor Author

/rehearse

@kubevirt-bot
Copy link
Copy Markdown
Contributor

⚠️ @nestoracunablanco you need to be an approver for all the files to run rehearsal.

@lyarwood can help run the rehearsal.

Details

If that doesn't work, ping someone from this list:

  • aglitke
  • davidvossel
  • phoracek
  • rmohr
  • tiraboschi
  • vladikr
  • xpivarc
  • dhiller
  • dollierp
  • enp0s3

@lyarwood
Copy link
Copy Markdown
Member

/rehearse

@kubevirt-bot
Copy link
Copy Markdown
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-functest-ubuntu-s390x
Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

@nestoracunablanco
Copy link
Copy Markdown
Contributor Author

@lyarwood I tried "make cluster-up" in a s390x VM and the gocli image is now built for s390x.
Can you please /rehearse again?

@lyarwood
Copy link
Copy Markdown
Member

/rehearse

@kubevirt-bot
Copy link
Copy Markdown
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-functest-ubuntu-s390x
Further information on rehearsals

A rehearsal can be triggered for all jobs by commenting either /rehearse or /rehearse all on this PR.

A rehearsal for a specific job can be triggered by commenting /rehearse {job-name}.

Commenting /rehearse ? triggers a comment with a list of jobs that can be rehearsed.

A pull request can be rehearsed if either the user is authorized to rehearse or the pull
request has the ok-to-rehearse label.

Authorized users are the group of users that are members of the KubeVirt GitHub
organization AND either are approvers[1] for all files in the pull request or are
top-level approvers[1] in the project-infra project.

[1]: see OWNERS file definition for reference.

@nestoracunablanco
Copy link
Copy Markdown
Contributor Author

@ksimon1 @lyarwood does this PR looks good to you?

@ksimon1
Copy link
Copy Markdown
Member

ksimon1 commented May 5, 2026

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@nestoracunablanco
Copy link
Copy Markdown
Contributor Author

/assign @lyarwood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants