aaq,presubmits: Add unit-test for s390x#4886
Conversation
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
pull-aaq-unit-test-s390xjob definesresources: requests:without any keys under it, which will make the YAML invalid or at least misleading; either remove the emptyresourcesblock or populate it with concrete CPU/memory requests similar to the other lanes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `pull-aaq-unit-test-s390x` job defines `resources:
requests:` without any keys under it, which will make the YAML invalid or at least misleading; either remove the empty `resources` block or populate it with concrete CPU/memory requests similar to the other lanes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
/rehearse |
|
@vladikr can help run the rehearsal. DetailsIf that doesn't work, ping someone from this list:
|
|
/retest-required |
|
@Barakmor1 could you PTAL? |
jschintag
force-pushed
the
aaq-unit-tests-s390x
branch
from
7643519 to
ff13f88
Compare
|
Rebased on on main |
|
@dollierp any idea how can we trigger it? Edit: nevermind seems like rehearse pull-aaq-unit-test-s390x worked |
|
/rehearse pull-aaq-unit-test-s390x |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
|
There seems to be a problem with the cluster setup, the pod is stuck on init: |
jschintag
force-pushed
the
aaq-unit-tests-s390x
branch
from
ff13f88 to
25fdf8d
Compare
|
/rehearse pull-aaq-unit-test-s390x |
|
@Barakmor1 can help run the rehearsal. DetailsIf that doesn't work, ping someone from this list:
|
|
/rehearse pull-aaq-unit-test-s390x |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Add a new test lane running unit-tests for aaq on s390x. Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
jschintag
force-pushed
the
aaq-unit-tests-s390x
branch
from
25fdf8d to
4c63714
Compare
|
/rehearse pull-aaq-unit-test-s390x |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
4 participants
Add a new test lane running unit-tests for aaq on s390x.
What this PR does / why we need it:
Add s390x unit-test lane for aaq
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note:
/cc @Barakmor1