-
Notifications
You must be signed in to change notification settings - Fork 173
Use k8s 1.35 for special network lanes #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following jobs have been updated: - IPv6 single stack - Optional lane with dynamic-networks-controller Signed-off-by: Orel Misan <omisan@redhat.com>
The following jobs have been updated: - IPv6 single stack - With dynamic-networks-controller Signed-off-by: Orel Misan <omisan@redhat.com>
|
Related Documentation No published documentation to review for changes on this repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider centralizing the k8s version used by these network lanes (e.g., via a shared variable or anchor) so that future version bumps don’t require manual string updates in multiple job names and TARGET values.
- Double-check whether there are any related references (e.g., dashboards, job filters, or alerts) that still point to the old
k8s-1.34-*-sig-networkjob names so they remain aligned with the new 1.35 lanes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the k8s version used by these network lanes (e.g., via a shared variable or anchor) so that future version bumps don’t require manual string updates in multiple job names and TARGET values.
- Double-check whether there are any related references (e.g., dashboards, job filters, or alerts) that still point to the old `k8s-1.34-*-sig-network` job names so they remain aligned with the new 1.35 lanes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
frenzyfriday
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
nirdothan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that regular 4.35 network lanes are already pretty stable. Thank you!
|
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
What this PR does / why we need it:
Update the special presubmit and periodic network jobs to use k8s v1.35.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: