Skip to content

Conversation

@orelmisan
Copy link
Member

What this PR does / why we need it:
Update the special presubmit and periodic network jobs to use k8s v1.35.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

The following jobs have been updated:
- IPv6 single stack
- Optional lane with dynamic-networks-controller

Signed-off-by: Orel Misan <omisan@redhat.com>
The following jobs have been updated:
- IPv6 single stack
- With dynamic-networks-controller

Signed-off-by: Orel Misan <omisan@redhat.com>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Feb 1, 2026
@dosubot
Copy link

dosubot bot commented Feb 1, 2026

Related Documentation

No published documentation to review for changes on this repository.

Write your first living document

How did I do? Any feedback?  Join Discord

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vladikr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@orelmisan
Copy link
Member Author

/cc @nirdothan @frenzyfriday

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider centralizing the k8s version used by these network lanes (e.g., via a shared variable or anchor) so that future version bumps don’t require manual string updates in multiple job names and TARGET values.
  • Double-check whether there are any related references (e.g., dashboards, job filters, or alerts) that still point to the old k8s-1.34-*-sig-network job names so they remain aligned with the new 1.35 lanes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider centralizing the k8s version used by these network lanes (e.g., via a shared variable or anchor) so that future version bumps don’t require manual string updates in multiple job names and TARGET values.
- Double-check whether there are any related references (e.g., dashboards, job filters, or alerts) that still point to the old `k8s-1.34-*-sig-network` job names so they remain aligned with the new 1.35 lanes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2026
Copy link
Member

@nirdothan nirdothan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that regular 4.35 network lanes are already pretty stable. Thank you!

@kubevirt-bot
Copy link
Contributor

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants