Add mshv-amd64-sig-compute-parallel job#4685
Conversation
|
Skipping CI for Draft Pull Request. |
kubevirt-bot
added
do-not-merge/work-in-progress
harshitgupta1337
force-pushed
the
mshv-sig-compute-serial-job
branch
from
a0bb137 to
b0d89fa
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml:2365-2366` </location>
<code_context>
+ - -ce
+ - automation/test.sh
+ env:
+ - name: TARGET
+ value: kind-1.33-wg-mshv-amd64-sig-compute-serial
+ - name: KUBEVIRTCI_TAG
+ value: "2512052315-50023d28"
</code_context>
<issue_to_address>
**issue (bug_risk):** TARGET value does not match the job name and may be a typo ('wg-' prefix).
`TARGET` is `kind-1.33-wg-mshv-amd64-sig-compute-serial` while the job name is `pull-kubevirt-e2e-kind-1.33-mshv-amd64-sig-compute-serial`. If `TARGET` is used by `automation/test.sh` to select a scenario, the extra `wg-` may cause a mismatch or wrong scenario. Please either align `TARGET` with the job name or confirm that the `wg-` prefix is intentional and handled downstream.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
/test check-prow-config |
harshitgupta1337
force-pushed
the
mshv-sig-compute-serial-job
branch
2 times, most recently
from
92fb2f4 to
14b18e0
Compare
harshitgupta1337
force-pushed
the
mshv-sig-compute-serial-job
branch
from
14b18e0 to
5c8e508
Compare
dhiller
left a comment
dhiller
left a comment
There was a problem hiding this comment.
@harshitgupta1337 thanks for the pull request, looks good already - some comments inline.
/approve
/hold to address the comments
| env: | ||
| - name: TARGET | ||
| value: kind-1.33-sig-compute-parallel-wg-mshv-amd64 | ||
| image: quay.io/kubevirtci/bootstrap:v20251218-e7a7fc9 |
There was a problem hiding this comment.
nit: this is an old bootstrap image - however that will be updated automatically
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhiller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Looks good overall but I'm afraid the labels will have to be adjusted. /rehearse pull-kubevirt-e2e-kind-1.33-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
| grace_period: 5m0s | ||
| timeout: 7h0m0s | ||
| labels: | ||
| preset-bazel-cache: "true" |
There was a problem hiding this comment.
As I suspected the Prow test Pod can't be scheduled on your cluster with all those labels because some services are not running on it.
You should probably use the same labels as the arm64 e2e job: https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml#L1196-L1238.
There was a problem hiding this comment.
Ok. Updating the labels of the MSHV job to match those in the pull-kubevirt-e2e-k8s-1.34-sig-compute-arm64 job. Now it reads the following.
labels:
preset-podman-in-container-enabled: "true"
harshitgupta1337
changed the title
harshitgupta1337
force-pushed
the
mshv-sig-compute-serial-job
branch
from
2781d7f to
a0ce583
Compare
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Based on the following test runs: - 2050234368068161536 - 2050204117330038784 - 2045650300844380160 Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
Re-running by skipping 33 individually named tests in total. Skip test calculated based on the following runs: |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
Re-running by skipping 33 individually named tests in total. Skip test calculated based on the following runs:
|
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
/rehearse pull-kubevirt-e2e-kind-1.35-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
/rehearse pull-kubevirt-e2e-kind-1.35-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
kubevirt-bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
/rehearse pull-kubevirt-e2e-kind-1.35-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
/rehearse pull-kubevirt-e2e-kind-1.35-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
/rehearse pull-kubevirt-e2e-kind-1.35-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
|
/rehearse pull-kubevirt-e2e-kind-1.35-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
Signed-off-by: Harshit Gupta <guptaharshit@microsoft.com>
|
/rehearse pull-kubevirt-e2e-kind-1.35-sig-compute-parallel-wg-mshv-amd64 |
|
Rehearsal jobs created for this PR: Further information on rehearsalsA rehearsal can be triggered for all jobs by commenting either A rehearsal for a specific job can be triggered by commenting Commenting A pull request can be rehearsed if either the user is authorized to rehearse or the pull Authorized users are the group of users that are members of the KubeVirt GitHub [1]: see OWNERS file definition for reference. |
|
@harshitgupta1337: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
What this PR does / why we need it:
This PR adds a
sig-compute-paralleltest lane for the HyperV-Direct hypervisor (MSHV) on AMD64 architecture.Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: