Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run hack/bump-prow.sh #3117

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

kubevirt-bot
Copy link
Contributor

Bump Prow

/cc @kubevirt/prow-job-taskforce

Signed-off-by: kubevirt-bot <[email protected]>
@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: GitHub didn't allow me to request PR reviews from the following users: kubevirt/prow-job-taskforce.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Bump Prow

/cc @kubevirt/prow-job-taskforce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Dec 8, 2023
@dhiller dhiller closed this Dec 8, 2023
@dhiller dhiller reopened this Dec 8, 2023
@dhiller
Copy link
Contributor

dhiller commented Dec 8, 2023

@dhiller's review-bot says:

  • 👍 This looks like a simple prow job image bump.
  • 👎 This doesn't look like a simple prow autobump.

I found suspicious hunks:

github/ci/prow-deploy/kustom/base/manifests/test_infra/current/prowjob-crd/prowjob_customresourcedefinition.yaml

               reporter_config:
                 description: ReporterConfig holds reporter-specific configuration
                 properties:
+                  resultstore:
+                    description: 'TODO: This config is used only for alpha testing
+                      and will likely move to ProwJobDefaults for flexibility.'
+                    properties:
+                      project_id:
+                        description: Specifies the ResultStore InvocationAttributes.ProjectId,
+                          used for various quota and GUI access control purposes.
+                          In practice, it is generally the same as the Google Cloud
+                          Project ID or number of the job's GCS storage bucket. Required
+                          to write job results to ResultStore.
+                        type: string
+                    type: object
                   slack:
                     properties:
                       channel:

This PR does not satisfy at least one automated review criteria.

Holding this PR for further manual action to occur.

/hold

Note: botreview (#2448) is a Work In Progress!

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2023
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@kubevirt-bot kubevirt-bot merged commit 9c3ed7d into kubevirt:main Dec 8, 2023
5 checks passed
@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: Updated the following 2 configmaps:

  • job-config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key project-infra-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-periodics.yaml
    • key project-infra-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-postsubmits.yaml
    • key project-infra-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml
  • config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key config.yaml using file github/ci/prow-deploy/kustom/base/configs/current/config/config.yaml

In response to this:

Bump Prow

/cc @kubevirt/prow-job-taskforce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants