Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run hack/bump-prow.sh #2485

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

kubevirt-bot
Copy link
Contributor

Bump Prow /cc @kubevirt/prow-job-taskforce

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 25, 2022
@dhiller
Copy link
Contributor

dhiller commented Nov 25, 2022

@dhiller's review-bot says:

This looks like a simple prow autobump. The bot approves.

/lgtm
/approve

Note: the bot holds for manual removal when the time is right for this to go in.

/hold

Note: botreview (#2448) is a Work In Progress!

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2022
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2022
@dhiller
Copy link
Contributor

dhiller commented Dec 9, 2022

@dhiller's review-bot says:

This doesn't look like a simple prow autobump.

These are the suspicious hunks I found:

                 description: JobQueueName is an optional field with name of a queue
                   defining max concurrency. When several jobs from the same queue
                   try to run at the same time, the number of them that is actually
-                  started is limited by JobQueueConcurrencies (part of Plank's config).
+                  started is limited by JobQueueCapacities (part of Plank's config).
                   If this field is left undefined inifinite concurrency is assumed.
                   This behaviour may be superseded by MaxConcurrency field, if it
                   is set to a constraining value.

Note: botreview (#2448) is a Work In Progress!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2022
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
Signed-off-by: kubevirt-bot <[email protected]>
@dhiller
Copy link
Contributor

dhiller commented Jan 6, 2023

/approve

@brianmcarey I think we can take this in. WDYT?

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it should be ok.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2023
@brianmcarey
Copy link
Member

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2023
@kubevirt-bot kubevirt-bot merged commit 59d635e into kubevirt:main Jan 6, 2023
@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: Updated the following 2 configmaps:

  • config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key config.yaml using file github/ci/prow-deploy/kustom/base/configs/current/config/config.yaml
  • job-config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key project-infra-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-periodics.yaml
    • key project-infra-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-postsubmits.yaml
    • key project-infra-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

In response to this:

Bump Prow /cc @kubevirt/prow-job-taskforce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants