Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ObjectTransfer feature #3418

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Deprecate ObjectTransfer feature #3418

merged 1 commit into from
Sep 4, 2024

Conversation

ShellyKa13
Copy link
Contributor

@ShellyKa13 ShellyKa13 commented Sep 1, 2024 •
edited
Loading

Added warnings and comments to ObjectTransfer crd and webhook.
Reference to relevant github issue:
#3417

Release note:

Deprecating ObjectTransfer feature

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Sep 1, 2024
@coveralls
Copy link

Coverage Status

coverage: 59.155% (-0.01%) from 59.165%
when pulling 5010649 on ShellyKa13:deprecate-OT
into e00c92a on kubevirt:main.

@akalenyu
Copy link
Collaborator

akalenyu commented Sep 1, 2024

So there's this reference for a deprecation that occurred in kubevirt:
kubevirt/kubevirt#8069
Which seems to also specify the deprecation field on the CRD. Maybe we want this too?

@ShellyKa13
Copy link
Contributor Author

@akalenyu Added, please review again. Thanks!

@ShellyKa13
Copy link
Contributor Author

/retest

@ShellyKa13
Deprecate ObjectTransfer feature
785cb61 
Add deprecation comments and warning to the crd.
Add warning to ObjectTransfer webhook and comment
with reference to relevant github issue:
kubevirt#3417

Signed-off-by: Shelly Kagan <[email protected]>
@akalenyu
Copy link
Collaborator

akalenyu commented Sep 2, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
@mhenriks
Copy link
Member

mhenriks commented Sep 3, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@akalenyu
Copy link
Collaborator

akalenyu commented Sep 4, 2024 •
edited
Loading

/test pull-containerized-data-importer-e2e-ceph-wffc

ERROR: checking pvc target-dv phase failed: etcdserver: request timed out

This etcd failure stuff is super weird. It's been making our polling funcs return early due to an error
which historically would never happen.
I will try to run some dummy PRs against older CDI branches to scratch out the possibility that we have some
insane hotlooping that overwhelms etcd.
EDIT:
#3426

@kubevirt-bot kubevirt-bot merged commit 7eedc09 into kubevirt:main Sep 4, 2024
19 checks passed
universal-itengineer pushed a commit to deckhouse/3p-containerized-data-importer that referenced this pull request Oct 29, 2024
@ShellyKa13 @universal-itengineer
Deprecate ObjectTransfer feature (kubevirt#3418)
7d7d20b 
Add deprecation comments and warning to the crd.
Add warning to ObjectTransfer webhook and comment
with reference to relevant github issue:
kubevirt#3417

Signed-off-by: Shelly Kagan <[email protected]>
universal-itengineer pushed a commit to deckhouse/3p-containerized-data-importer that referenced this pull request Oct 29, 2024
@ShellyKa13 @universal-itengineer
Deprecate ObjectTransfer feature (kubevirt#3418)
ed725ae 
Add deprecation comments and warning to the crd.
Add warning to ObjectTransfer webhook and comment
with reference to relevant github issue:
kubevirt#3417

Signed-off-by: Shelly Kagan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alromeros alromeros Awaiting requested review from alromeros

@arnongilboa arnongilboa Awaiting requested review from arnongilboa

Assignees

@akalenyu akalenyu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShellyKa13 @coveralls @akalenyu @mhenriks @kubevirt-bot