Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 0.97] bump go git v5.13.0 #1973

Merged

Conversation

RamLavi
Copy link
Collaborator

@RamLavi RamLavi commented Jan 8, 2025

What this PR does / why we need it:
This is a semi-automated cherry-pick of #1971
No conflicts during cherry-pick.

Special notes for your reviewer:

Release note:

NONE

* tools/bumper: Remove io/ioutil deprecated functions

Signed-off-by: Ram Lavi <[email protected]>

* tools/bumper: assert unhandled errors

Signed-off-by: Ram Lavi <[email protected]>

* vendor, tools/bumper: Bump go-git to v5.13.0

Also syntacticaly change the bumper unit test infra to get the
desired git repo for the unit tests.

Signed-off-by: Ram Lavi <[email protected]>

---------

Signed-off-by: Ram Lavi <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 8, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 8, 2025

/approve

@kubevirt-bot kubevirt-bot requested review from oshoval and qinqon January 8, 2025 08:54
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL labels Jan 8, 2025
Copy link

sonarqubecloud bot commented Jan 8, 2025

@oshoval
Copy link
Collaborator

oshoval commented Jan 8, 2025

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 8, 2025

/retest

opened an KMP issue to monitor this failure

@RamLavi
Copy link
Collaborator Author

RamLavi commented Jan 8, 2025

/retest
tests failed on etcdserver: request timed out

@kubevirt-bot kubevirt-bot merged commit caaeca8 into kubevirt:release-0.97 Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants