-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lifecycle: Update RELEASES_SELECTOR #1869
Conversation
Hey @oshoval thanks for the change, |
Hi, I know and mentioned it as well on other PR today. |
Remove old versions (keep 3 versions + release candid). Update outdated version to use latest release of each minor. Add missing releases. Signed-off-by: Or Shoval <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
We should consider improving this flow, it can be semi automated |
/test pull-e2e-cnao-multus-dynamic-networks-functests |
@RamLavi |
/lgtm according review i dont see something blocking |
@oshoval: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I wanted to suggest that we wait until the GA date so that we could remove another release from the list. |
Thanks, but there is no reason to wait for that, we can always remove that once it comes. |
What this PR does / why we need it:
Remove old versions (keep 3 versions + release candid).
Update outdated version to use latest release of each minor.
Add missing releases.
Special notes for your reviewer:
Created this helper script, it will make this process less prone for mistakes
#1872
Release note: