Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle: Update RELEASES_SELECTOR #1869

Merged
merged 1 commit into from
Aug 18, 2024
Merged

lifecycle: Update RELEASES_SELECTOR #1869

merged 1 commit into from
Aug 18, 2024

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Aug 18, 2024

What this PR does / why we need it:
Remove old versions (keep 3 versions + release candid).
Update outdated version to use latest release of each minor.
Add missing releases.

Special notes for your reviewer:
Created this helper script, it will make this process less prone for mistakes
#1872

Release note:

None

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 18, 2024
@kubevirt-bot kubevirt-bot requested review from qinqon and RamLavi August 18, 2024 08:45
@kubevirt-bot kubevirt-bot added size/XS release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 18, 2024
@RamLavi
Copy link
Collaborator

RamLavi commented Aug 18, 2024

Hey @oshoval thanks for the change,
This only changes the "short" lifecycle, that runs on every non-release PR
But we still have to update the "long" lifecycle, that runs over all the supported releases, and runs on every release PR.
Please consider updating that as well.

@oshoval oshoval changed the title lifecycle: Update releases WIP lifecycle: Update releases Aug 18, 2024
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 18, 2024

Hey @oshoval thanks for the change, This only changes the "short" lifecycle, that runs on every non-release PR But we still have to update the "long" lifecycle, that runs over all the supported releases, and runs on every release PR. Please consider updating that as well.

Hi, I know and mentioned it as well on other PR today.
If you want please go ahead, atm I am focusing on short lifecyle.

@oshoval oshoval changed the title WIP lifecycle: Update releases WIP lifecycle: Update RELEASES_SELECTOR Aug 18, 2024
Remove old versions (keep 3 versions + release candid).
Update outdated version to use latest release of each minor.
Add missing releases.

Signed-off-by: Or Shoval <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 18, 2024

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-cnao-multus-dynamic-networks-functests 23c5c73 link true /test pull-e2e-cnao-multus-dynamic-networks-functests

#1871

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 18, 2024

We should consider improving this flow, it can be semi automated
this way it will be less prone for mistakes

@oshoval oshoval changed the title WIP lifecycle: Update RELEASES_SELECTOR lifecycle: Update RELEASES_SELECTOR Aug 18, 2024
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2024
@oshoval
Copy link
Collaborator Author

oshoval commented Aug 18, 2024

/test pull-e2e-cnao-multus-dynamic-networks-functests

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 18, 2024

@RamLavi
all lanes pass, do you want to review please ?
(sonar will be ignored for now)

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 18, 2024

/lgtm
/approve

according review i dont see something blocking
we can always fix in case any thing needed anyhow

@kubevirt-bot
Copy link
Collaborator

@oshoval: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

according review i dont see something blocking
we can always fix in case any thing needed anyhow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oshoval

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2024
@oshoval oshoval added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2024
@oshoval oshoval merged commit c3b4ee6 into kubevirt:main Aug 18, 2024
14 of 16 checks passed
@RamLavi
Copy link
Collaborator

RamLavi commented Aug 18, 2024

I wanted to suggest that we wait until the GA date so that we could remove another release from the list.
But I see that you already forced merge.

@oshoval
Copy link
Collaborator Author

oshoval commented Aug 18, 2024

Thanks, but there is no reason to wait for that, we can always remove that once it comes.
I pro unblocking stuff, small PRs, unless there is a reason to create dependencies.
Moreover, i kept here a window of 3 + RC (window of 4) + main, i think it is better than tight 3 + main.
We usually do that btw (length of the env var stayed the same, even that it was with non correct values).
Shrinking the window deserves its own PR and discussion, for sure not on this PR please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants