Skip to content

Conversation

@mansam
Copy link
Contributor

@mansam mansam commented Dec 12, 2024

  • Exposes OVA appliance disks as mappable storage in the OVA inventory collector.
  • Permits mapping any or all OVA appliance disks to their own destination storage classes.
  • This requires a UI change in order to list the source disks in the storage mapping creation view properly. This case needs to be replaced with code similar to the other providers to list the source storage (disks) belonging to the selected VMs.

Implements #1213

Note: Please ignore default mapping in below screenshots, the default mapping has been removed.

image
image
image

See https://issues.redhat.com/browse/MTV-1340

@mansam mansam requested review from mnecas and yaacov as code owners December 12, 2024 20:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 15.42%. Comparing base (b0b9ae7) to head (e49a10f).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/plan/adapter/ova/builder.go 0.00% 49 Missing ⚠️
pkg/controller/plan/adapter/ova/validator.go 0.00% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
- Coverage   15.61%   15.42%   -0.20%     
==========================================
  Files         112      112              
  Lines       23134    23426     +292     
==========================================
+ Hits         3612     3613       +1     
- Misses      19237    19528     +291     
  Partials      285      285              
Flag Coverage Δ
unittests 15.42% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mansam mansam closed this Dec 12, 2024
@mansam mansam reopened this Dec 13, 2024
@mansam mansam closed this Dec 16, 2024
@mansam mansam reopened this Dec 16, 2024
* Exposes OVA appliance disks as mappable storage
  in the OVA inventory collector.
* Permits mapping any or all OVA appliance disks
  to their own destination storage classes.
* Any disks that are not specifically mapped are
  assigned to a default storage class, which must
  be given a storage mapping.

Signed-off-by: Sam Lucidi <[email protected]>
@sonarqubecloud
Copy link

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before merging this we need to sync with the UI and docs

@mansam
Copy link
Contributor Author

mansam commented Dec 23, 2024

Storages:
image
Disks:
image
I've pushed a forklift-controller image including these changes to my quay account quay.io/slucidi/forklift-controller:ova-multidisk

@mnecas mnecas added this to the 2.9.0 milestone May 12, 2025
@mnecas mnecas merged commit 7dbfff7 into kubev2v:main May 12, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants