Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Tweak wording in pre-reqs.md #2239

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

MikeSpreitzer
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer commented Jun 21, 2024

Summary

This PR makes some small improvements to the wording in the pre-reqs document.

Preview at https://mikespreitzer.github.io/kcp-edge-mc/doc-update-621b/direct/pre-reqs/

Related issue(s)

Fixes #

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2024
@MikeSpreitzer
Copy link
Contributor Author

/cc @KPRoche

@kcp-ci-bot kcp-ci-bot requested a review from KPRoche June 21, 2024 21:00
Signed-off-by: Mike Spreitzer <[email protected]>
@KPRoche
Copy link
Contributor

KPRoche commented Jun 21, 2024

I like the expanded opening!

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3a3ea65a1024a82db35657f12e0ba62c625dc2e0

@MikeSpreitzer
Copy link
Contributor Author

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MikeSpreitzer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2024
@kcp-ci-bot kcp-ci-bot merged commit 12c78ef into kubestellar:main Jun 23, 2024
10 checks passed
@MikeSpreitzer MikeSpreitzer deleted the doc-update-621b branch June 23, 2024 04:36
@MikeSpreitzer MikeSpreitzer restored the doc-update-621b branch June 23, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants