Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 [release-0.23.0] Remove the report of deploying on k3d #2237

Merged

Conversation

MikeSpreitzer
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer commented Jun 21, 2024

Summary

This PR deletes the report of how to run KubeStellar release 0.22.0 on three new k3d clusters. This is good because nobody wanted to maintain it and nobody wanted to see a non-maintained document. This is bad because it is deleting information that took time to develop and we do not want to lose. The good news is that Git remembers and we have it published at https://docs.kubestellar.io/release-0.22.0/direct/deploy-on-k3d/ , and with all the stress over it, we are not likely to soon forget that we had it.

Preview at https://mikespreitzer.github.io/kcp-edge-mc/doc-delete-k3d-report/readme/

Related issue(s)

This is one way to resolve issue #2230 in one specific branch, release-0.23.0 --- which is the one that currently drives the default version of the website. PR #2234 is another. I hope that the website work in main will distribute the interesting content from this report into the user guide material about how to set up KubeStellar.

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2024
@MikeSpreitzer MikeSpreitzer changed the title Remove the report of deploying on k3d 📖 Remove the report of deploying on k3d Jun 21, 2024
@MikeSpreitzer
Copy link
Contributor Author

/cc @clubanderson
/cc @eaepstein
/cc @KPRoche

@MikeSpreitzer MikeSpreitzer changed the title 📖 Remove the report of deploying on k3d 📖 [release-0.23.0] Remove the report of deploying on k3d Jun 21, 2024
@ezrasilvera
Copy link
Contributor

@MikeSpreitzer As I wrote in the other PR - I think this should be presented in all versions, however it should be put as an "example integration" with specific version pointer.

@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2024
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2024
Signed-off-by: Mike Spreitzer <[email protected]>
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 27, 2024
@ezrasilvera
Copy link
Contributor

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9e81044eb81bd021a0f39c9cc40329e26998cdd

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezrasilvera

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@kcp-ci-bot kcp-ci-bot merged commit 798982c into kubestellar:release-0.23.0 Jun 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants