-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Update best-practices.md to update the spelling of Kubernetes #2227
Conversation
Hi @rchen-devv. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting your first Pull Request to KubeStellar. We are delighted to have you in our Universe!
thanks for the fix - let me have a look |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
LGTM label has been added. Git tree hash: d4668c489f4179e863a6dc25f82537910730c4bf
|
fixes kubestellar#2222 Signed-off-by: Rchen450 <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A note -- this is fixed in the file on the new website from PR #2229 but that doesn't display at kubestellar.io yet |
@rchen-devv the new site was published a few hours ago. Check if this spelling is fixed already. If so, close this PR. You still get credit for the PR! |
Note that until the next release triggers a render, the new site can be previewed at https://kproche.github.io/kubestellar/doc-new-v2 And this page in particular is at https://kproche.github.io/kubestellar/doc-new-v2/direct/best-practices/ |
Just checked out the new site and its look good to me. Will close this PR. |
fixes #2222
Summary
Related issue(s)
Fixes #2222