Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Update best-practices.md to update the spelling of Kubernetes #2227

Closed
wants to merge 1 commit into from

Conversation

rchen-devv
Copy link
Contributor

fixes #2222

Summary

Related issue(s)

Fixes #2222

@kcp-ci-bot kcp-ci-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2024
@kcp-ci-bot
Copy link
Contributor

Hi @rchen-devv. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first Pull Request to KubeStellar. We are delighted to have you in our Universe!

@clubanderson clubanderson self-assigned this Jun 20, 2024
@clubanderson
Copy link
Collaborator

thanks for the fix - let me have a look

@clubanderson clubanderson changed the title Update best-practices.md to update the spelling of Kubernetes 馃悰 Update best-practices.md to update the spelling of Kubernetes Jun 20, 2024
@clubanderson
Copy link
Collaborator

/ok-to-test

@kcp-ci-bot kcp-ci-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 20, 2024
Copy link
Contributor

@MikeSpreitzer MikeSpreitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4668c489f4179e863a6dc25f82537910730c4bf

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 21, 2024
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KPRoche
Copy link
Contributor

KPRoche commented Jun 21, 2024

A note -- this is fixed in the file on the new website from PR #2229 but that doesn't display at kubestellar.io yet

@clubanderson
Copy link
Collaborator

@rchen-devv the new site was published a few hours ago. Check if this spelling is fixed already. If so, close this PR. You still get credit for the PR!

@KPRoche
Copy link
Contributor

KPRoche commented Jun 21, 2024

@rchen-devv the new site was published a few hours ago. Check if this spelling is fixed already. If so, close this PR. You still get credit for the PR!

Note that until the next release triggers a render, the new site can be previewed at https://kproche.github.io/kubestellar/doc-new-v2

And this page in particular is at https://kproche.github.io/kubestellar/doc-new-v2/direct/best-practices/

@rchen-devv
Copy link
Contributor Author

Just checked out the new site and its look good to me. Will close this PR.

@rchen-devv rchen-devv closed this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: Kubernetes spelled wrong
5 participants