-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicated glossary entry for CRI #48794
base: main
Are you sure you want to change the base?
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: cb6eabe4ba0a88facb2149608043d01f2b8d5253
|
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Dmitry Shurupov <[email protected]> Co-authored-by: Tim Bannister <[email protected]>
b87f7ec
to
23b3e52
Compare
Thanks, @sftim! I applied your suggestion and squashed it. A new |
Currently, we have two conflicting glossary entries for CRI:
content/en/docs/reference/glossary/cri.md
(added in 2019 via Add CRI to glossary #13024)content/en/docs/reference/glossary/container-runtime-interface.md
(added in 2021 via Add CRI architecture to cluster concepts #30606)If you open the actual glossary, the first one will be displayed only under the name "Container runtime interface (CRI)".
This PR:
cri.md
in favour ofcontainer-runtime-interface.md
(since the latter was added/reviewed more recently);container-runtime-interface.md
file tocri.md
(because this is how it's currently done forcni
andcsi
);cri.md
: itsterm_id
becomescri
, its title becomesContainer Runtime Interface (CRI)
(includes the abbreviation), itstags
changed fromcri
tofundamental
(that's how it was for the currently displayed CRI entry);<glossary_tooltip term_id="container-runtime-interface"...>
entries to the newterm_id
(i.e.cri
).