Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated glossary entry for CRI #48794

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shurup
Copy link
Member

@shurup shurup commented Nov 21, 2024

Currently, we have two conflicting glossary entries for CRI:

If you open the actual glossary, the first one will be displayed only under the name "Container runtime interface (CRI)".

This PR:

  • removes the current cri.md in favour of container-runtime-interface.md (since the latter was added/reviewed more recently);
  • renames current container-runtime-interface.md file to cri.md (because this is how it's currently done for cni and csi);
  • makes a few technical changes to a new cri.md: its term_id becomes cri, its title becomes Container Runtime Interface (CRI) (includes the abbreviation), its tags changed from cri to fundamental (that's how it was for the currently displayed CRI entry);
  • substitutes all existing <glossary_tooltip term_id="container-runtime-interface"...> entries to the new term_id (i.e. cri).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2024
Copy link

netlify bot commented Nov 21, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fb8a0e0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/673ec83f943594000854e774
😎 Deploy Preview https://deploy-preview-48794--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

content/en/docs/reference/glossary/cri.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cb6eabe4ba0a88facb2149608043d01f2b8d5253

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sftim. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Dmitry Shurupov <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
@shurup
Copy link
Member Author

shurup commented Nov 25, 2024

Thanks, @sftim! I applied your suggestion and squashed it. A new lgtm is needed, though 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants