-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #48705
base: main
Are you sure you want to change the base?
Update README.md #48705
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Priyanka0300! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'm uncertain if the formatting of the prerequisites section aligns with our style guide. Any suggestions on this would be appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, just a couple minor comments.
README.md
Outdated
|
||
## Prerequisites | ||
|
||
To use this repository, you need the following installed locally: | ||
To use this repository, you'll need: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's anything in the style guide, but to make it maybe easier for non-English speakers, it might be better to not use contractions and say "you will need".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to review my work and provide feedback! I really appreciate your input . I’ve made the updates as you suggested .Let me know if there’s anything else you notice
Hi @tengqm, I’ve addressed all the feedback and made the requested changes. When you have a moment, could you review it again? If everything looks good, an LGTM label would be great. Thanks for your time! |
Pull Request: Updates to Kubernetes Documentation
Overview
This pull request includes updates to the Kubernetes documentation to improve clarity and ensure consistency across the site. The changes involve restructuring the instructions, improving formatting, and adding additional explanations to certain sections.
Key Changes:
Requesting Feedback
I would greatly appreciate feedback on the README.md file.
Next Steps
Once I receive feedback, I will address any comments or suggestions and make necessary updates to the documentation.
Thank you for taking the time to review this PR!
Closes: #41989