Skip to content

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Aug 24, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from medyagh and nirs August 24, 2025 13:17
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2025
@prezha prezha changed the title iso: update kernel lts version to 6.6.102 iso: update kernel lts version to 6.6.96 Aug 24, 2025
@prezha
Copy link
Contributor Author

prezha commented Aug 24, 2025

/ok-to-build-iso

@nirs
Copy link
Contributor

nirs commented Aug 24, 2025

Can you update the title to match the actual version?

@prezha
Copy link
Contributor Author

prezha commented Aug 24, 2025

/ok-to-build-iso

1 similar comment
@prezha
Copy link
Contributor Author

prezha commented Aug 24, 2025

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @prezha, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@prezha
Copy link
Contributor Author

prezha commented Aug 24, 2025

/ok-to-build-iso

@prezha prezha changed the title iso: update kernel lts version to 6.6.96 iso: update kernel lts version to 6.6.102 Aug 24, 2025
@prezha
Copy link
Contributor Author

prezha commented Aug 25, 2025

/ok-to-build-iso

1 similar comment
@prezha
Copy link
Contributor Author

prezha commented Aug 25, 2025

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @prezha, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@prezha prezha marked this pull request as draft August 25, 2025 10:05
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2025
@medyagh
Copy link
Member

medyagh commented Aug 25, 2025

ok-to-test

Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the kernel change to one commit? Keeping temporary debugging commits makes it harder to review and we don't want such commit in git history.

Updating the kernel makes sense for minkube 1.38 so we have enough time to detect issues. But we may want to move to newer kernel - when we updated to 6.6 6.12 build did not work, but it may be good now.

@prezha
Copy link
Contributor Author

prezha commented Sep 3, 2025

rebased to current master head and squashed commits

note that this was only for testing - for ruling out the kernel version being the problem for the issue with kube-proxy, which proved to be correct assumption, ie, i haven't looked into if we need some additional kernel config changes as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants