Skip to content

Conversation

nirs
Copy link
Contributor

@nirs nirs commented Aug 16, 2025

Add the missing Mount During Start section to describe how to mount a
directory when starting a cluster. This section describes the new
virtiofs mounts introduced in minikube 1.37.0.

Rename the 9p Mounts section to Mount Command to make it more clear.
This is an alternative for the Mount During Start if the user need to
mount more than one directory or mount or unmount directories after the
cluster was started. Remove the Kubernetes manifest example as it is not
specific to mount command.

Rename the Driver Mount section to Driver Automatic Mounts to make
it more clear, and remove drivers that do not support this feature.

Add Driver Specific Mounts for special mount options supported by
specific drivers, currently only HyperKit.

Reformat text tables to make the source easier to work with.

Issues:

  • Missing --mount-string support on Windows and other drivers I'm not
    sure what works and/or tested and we have too many drivers[1]
  • Add section for using mounts in Kubernetes manifests?

[1] https://minikube.sigs.k8s.io/docs/drivers/

Based on #21149 adding virtiofs support

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2025
@k8s-ci-robot k8s-ci-robot requested a review from medyagh August 16, 2025 18:09
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2025
@k8s-ci-robot k8s-ci-robot requested a review from prezha August 16, 2025 18:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nirs
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 16, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 18, 2025
@nirs nirs force-pushed the mount-docs branch 2 times, most recently from d88dd01 to 7f8ccfb Compare August 22, 2025 16:52
nirs added 2 commits September 1, 2025 21:33
Add the missing *Mount During Start* section to describe how to mount a
directory when starting a cluster. This section describes the new
virtiofs mounts introduced in minikube 1.37.0.

Rename the *9p Mounts* section to *Mount Command* to make it more clear.
This is an alternative for the *Mount During Start* if the user need to
mount more than one directory or mount or unmount directories after the
cluster was started. Remove the Kubernetes manifest example as it is not
specific to mount command.

Rename the *Driver Mount* section to *Driver Automatic Mounts* to make
it more clear, and remove drivers that do not support this feature.

Add *Driver Specific Mounts* for special mount options supported by
specific drivers, currently only HyperKit.

Reformat text tables to make the source easier to work with.

Issues:
- Missing `--mount-string` support on Windows and other drivers I'm not
  sure what works and/or tested and we have too many drivers[1]
- Add section for using mounts in Kubernetes manifests?

[1] https://minikube.sigs.k8s.io/docs/drivers/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants