Skip to content

krunkit: Disable offloading for faster networking #21341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

krunkit: Disable offloading for faster networking #21341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/drivers/krunkit/krunkit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ func (d *Driver) startKrunkit(socketPath string) error {
"--memory", fmt.Sprintf("%d", d.Memory),
"--cpus", fmt.Sprintf("%d", d.CPU),
"--restful-uri", d.restfulURI(),
"--device", fmt.Sprintf("virtio-net,unixSocketPath=%s,mac=%s", socketPath, d.MACAddress),
"--device", fmt.Sprintf("virtio-net,type=unixgram,path=%s,mac=%s,offloading=%t",
socketPath, d.MACAddress, d.VmnetHelper.Offloading),
"--device", fmt.Sprintf("virtio-serial,logFilePath=%s", d.serialPath()),
"--krun-log-level", logLevelInfo,

Expand Down
2 changes: 0 additions & 2 deletions pkg/minikube/registry/drvs/krunkit/krunkit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ func configure(cfg config.ClusterConfig, n config.Node) (interface{}, error) {
VmnetHelper: vmnet.Helper{
MachineDir: filepath.Join(storePath, "machines", machineName),
InterfaceID: u,
// Required Until https://github.com/containers/libkrun/issues/264 is fixed.
Offloading: true,
},
}, nil
}
Expand Down
2 changes: 1 addition & 1 deletion site/content/en/docs/drivers/krunkit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ workloads.
- Available only on Apple silicon.
- Requires macOS 13 or later.
- Requires minikube version 1.37.0 or later.
- Requires krunkit version 0.2.2 or later.
- Requires krunkit version 1.0.0 or later.
- Requires [vmnet-helper](https://github.com/nirs/vmnet-helper).

## Installing krunkit
Expand Down
Loading