skip tests not relevant for windows #21329
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| @@ -225,6 +226,9 @@ func TestDeleteAllProfiles(t *testing.T) { | |||
| // then tries to execute the tryKillOne function on it; | |||
| // if after tryKillOne the process still exists, we consider it a failure | |||
| func TestTryKillOne(t *testing.T) { | |||
There was a problem hiding this comment.
is it possible to make our Killing Func to work on windows?
There was a problem hiding this comment.
Yes.The test relied on platform-specific process/Wait() behavior and/or error text ("killed"). Windows and POSIX terminate processes differently: POSIX signals (SIGHUP/SIGKILL) and their wait/exit semantics differ from Windows TerminateProcess. The test assumed Windows Wait() would return a non-nil error that contains "killed", but in your environment Wait() returned nil. That mismatch made the assertion fail. Pushing a fix for this in a bit
| @@ -56,9 +56,8 @@ jobs: | |||
| run: choco install make -y | |||
| # TODO: add gopogh reports for unit tests too | |||
| - name: unit test | |||
| timeout-minutes: 5 | |||
| timeout-minutes: 15 | |||
prezha
force-pushed
the
fix-windows-unit-tests
branch
from
2cdb3ce to
a758221
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #21301