Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.33.1 #18840

Merged
merged 2 commits into from May 13, 2024
Merged

Release v1.33.1 #18840

merged 2 commits into from May 13, 2024

Conversation

spowelljr
Copy link
Member

Patch release for v1.33 to fix a few issues.

Not ready for merge yet, waiting for ISO and Kicbase release PRs to be merged first.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2024
@spowelljr spowelljr added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 8, 2024
medyagh
medyagh reviewed May 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2024
@spowelljr spowelljr removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2024
@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 9, 2024
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18840) |
+----------------+----------+---------------------+
| minikube start | 53.2s    | 52.8s               |
| enable ingress | 28.1s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 50.8s 51.4s 52.0s 57.3s 54.3s
Times for minikube (PR 18840) start: 52.0s 50.1s 56.6s 52.9s 52.2s

Times for minikube ingress: 28.1s 28.0s 28.1s 28.0s 28.1s
Times for minikube (PR 18840) ingress: 28.2s 27.6s 28.0s 29.5s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18840) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 23.5s               |
| enable ingress | 21.7s    | 21.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.0s 25.0s 24.0s 22.4s 22.6s
Times for minikube (PR 18840) start: 22.2s 24.2s 23.8s 24.5s 22.8s

Times for minikube ingress: 21.8s 21.3s 21.3s 21.8s 22.4s
Times for minikube (PR 18840) ingress: 21.3s 22.3s 21.3s 22.4s 22.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18840) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 22.4s               |
| enable ingress | 35.7s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.8s 32.8s 49.3s 31.8s 32.9s
Times for minikube (PR 18840) ingress: 31.8s 31.8s 32.3s 31.9s 31.8s

Times for minikube start: 22.5s 24.8s 24.2s 23.1s 24.5s
Times for minikube (PR 18840) start: 23.7s 23.9s 22.8s 21.3s 20.1s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd_arm64 TestFunctional/parallel/License (gopogh) 0.00 (chart)
Docker_Linux_containerd TestFunctional/parallel/License (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestFunctional/parallel/License (gopogh) 0.00 (chart)
Docker_Linux_crio TestFunctional/parallel/License (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestFunctional/parallel/License (gopogh) 0.00 (chart)
Docker_Linux TestFunctional/parallel/License (gopogh) 0.00 (chart)
KVM_Linux_containerd TestFunctional/parallel/License (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/parallel/License (gopogh) 0.00 (chart)
KVM_Linux TestFunctional/parallel/License (gopogh) 0.00 (chart)
none_Linux TestFunctional/parallel/License (gopogh) 0.00 (chart)
QEMU_macOS TestFunctional/parallel/License (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/parallel/License (gopogh) 1.00 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/Setup (gopogh) 2.00 (chart)
KVM_Linux_containerd TestAddons/parallel/Ingress (gopogh) 2.50 (chart)
Hyper-V_Windows TestPause/serial/PauseAgain (gopogh) 2.99 (chart)
Hyper-V_Windows TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh) 3.00 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/SSHCmd (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/parallel/Version/components (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/serial/LogsCmd (gopogh) 5.88 (chart)
QEMU_macOS TestFunctional/serial/LogsFileCmd (gopogh) 5.88 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 6.88 (chart)
QEMU_macOS TestAddons/Setup (gopogh) 7.06 (chart)
QEMU_macOS TestMultiControlPlane/serial/NodeLabels (gopogh) 7.81 (chart)
QEMU_macOS TestMultiControlPlane/serial/HAppyAfterSecondaryNodeRestart (gopogh) 7.94 (chart)
Hyper-V_Windows TestDockerFlags (gopogh) 9.20 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh
medyagh approved these changes May 13, 2024
View reviewed changes
CHANGELOG.md

Bugs:
* Fix `DNSSEC validation failed` errors [#18830](https://github.com/kubernetes/minikube/pull/18830)
* Fix `too many open files` errors [#18832](https://github.com/kubernetes/minikube/pull/18832)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe should mention (Fedora) in paranthesis ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone reported the issue on macOS, so might be more than just Fedora?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 248d1ec into kubernetes:master May 13, 2024
14 of 38 checks passed
@spowelljr spowelljr deleted the release1331 branch May 13, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spowelljr @minikube-pr-bot @k8s-ci-robot @medyagh