Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: bump github action macos machines to 13 #18531

Closed
wants to merge 7 commits into from
Closed

wip: bump github action macos machines to 13 #18531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12add34
bump github action macos machines to 13
medyagh Mar 28, 2024
0028df8
install vbox on macos 13, since it been removed from image
medyagh Mar 28, 2024
d7a5235
disable security first
medyagh Mar 28, 2024
dee977f
trying installing exten pack manually
medyagh Mar 28, 2024
467bbb4
adding SHA for agreeing to install vbox ext
medyagh Mar 28, 2024
923c555
echo y to ext license
medyagh Mar 28, 2024
75d2f54
macos 14
medyagh Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ jobs:
JOB_NAME: "functional_virtualbox_macos"
GOPOGH_RESULT: ""
SHELL: "/bin/bash" # To prevent https://github.com/kubernetes/minikube/issues/6643
runs-on: macos-12
runs-on: macos-13
steps:
- name: Install kubectl
shell: bash
Expand All @@ -429,6 +429,12 @@ jobs:
run: |
brew install docker-machine docker
sudo docker --version
- name: Install vbox
shell: bash
run: |
sudo spctl --master-disable
brew install --cask virtualbox
brew install --cask virtualbox-extension-pack
- name: Info
shell: bash
run: |
Expand All @@ -455,7 +461,7 @@ jobs:
chmod a+x e2e-*
chmod a+x minikube-*
START_TIME=$(date -u +%s)
KUBECONFIG=$(pwd)/testhome/kubeconfig MINIKUBE_HOME=$(pwd)/testhome ./e2e-darwin-amd64 -minikube-start-args=--vm-driver=virtualbox -test.run "TestFunctional" -test.timeout=35m -test.v -timeout-multiplier=1.5 -binary=./minikube-darwin-amd64 2>&1 | tee ./report/testout.txt
KUBECONFIG=$(pwd)/testhome/kubeconfig MINIKUBE_HOME=$(pwd)/testhome ./e2e-darwin-amd64 -minikube-start-args=--vm-driver=virtualbox -test.run "TestFunctional" -test.timeout=55m -test.v -timeout-multiplier=1.8 -binary=./minikube-darwin-amd64 2>&1 | tee ./report/testout.txt
END_TIME=$(date -u +%s)
TIME_ELAPSED=$(($END_TIME-$START_TIME))
min=$((${TIME_ELAPSED}/60))
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ jobs:
JOB_NAME: "functional_virtualbox_macos"
GOPOGH_RESULT: ""
SHELL: "/bin/bash" # To prevent https://github.com/kubernetes/minikube/issues/6643
runs-on: macos-12
runs-on: macos-14
steps:
- name: Install kubectl
shell: bash
Expand All @@ -547,6 +547,16 @@ jobs:
run: |
brew install docker-machine docker
sudo docker --version
- name: Install vbox
shell: bash
run: |
brew update
brew search virtualbox
sudo spctl --master-disable
brew install --cask virtualbox
curl -O -L "https://download.virtualbox.org/virtualbox/7.0.14/Oracle_VM_VirtualBox_Extension_Pack-7.0.14.vbox-extpack"
# Get SHAs from installing it manually once and then it will spit out the SHA for batch installation
echo "y" | sudo VBoxManage extpack install Oracle_VM_VirtualBox_Extension_Pack-7.0.14.vbox-extpack --accept-license=33d7284dc4a0ece381196fda3cfe2ed0e1e8e7ed7f27b9a9ebc4ee22e24bd23c
- name: Info
shell: bash
run: |
Expand Down Expand Up @@ -574,7 +584,7 @@ jobs:
chmod a+x minikube-*
MINIKUBE_HOME=$(pwd)/testhome ./minikube-darwin-amd64 delete --all --purge
START_TIME=$(date -u +%s)
KUBECONFIG=$(pwd)/testhome/kubeconfig MINIKUBE_HOME=$(pwd)/testhome ./e2e-darwin-amd64 -minikube-start-args=--vm-driver=virtualbox -test.run "TestFunctional" -test.timeout=35m -test.v -timeout-multiplier=1.5 -binary=./minikube-darwin-amd64 2>&1 | tee ./report/testout.txt
KUBECONFIG=$(pwd)/testhome/kubeconfig MINIKUBE_HOME=$(pwd)/testhome ./e2e-darwin-amd64 -minikube-start-args=--vm-driver=virtualbox -test.run "TestFunctional" -test.timeout=55m -test.v -timeout-multiplier=1.8 -binary=./minikube-darwin-amd64 2>&1 | tee ./report/testout.txt
END_TIME=$(date -u +%s)
TIME_ELAPSED=$(($END_TIME-$START_TIME))
min=$((${TIME_ELAPSED}/60))
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/time-to-k8s-public-chart.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
./hack/benchmark/time-to-k8s/public-chart/public-chart.sh docker containerd
time-to-k8s-public-chart-virtualbox:
if: github.repository == 'kubernetes/minikube'
runs-on: macos-12
runs-on: macos-13
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down
Loading