Base ISO cache file name on the full ISO URL

Currently, only the final component of the URL path is used. This means that minikube may use the wrong cached image after the user changes the ISO URL to another with the same final component. Base the cache file name on the full URL instead, encoding it using Go's base64.URLEncoding so it can be used as a file name on all platforms. Signed-off-by: Alberto Faria <[email protected]>
kubernetes · Apr 24, 2024 · abc0d3b · abc0d3b
1 parent 98bd6df
commit abc0d3b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/minikube/download/iso.go b/pkg/minikube/download/iso.go
@@ -17,10 +17,10 @@ limitations under the License.
 package download
 
 import (
+ "encoding/base64"
  "fmt"
  "net/url"
  "os"
- "path"
  "path/filepath"
  "runtime"
  "strings"
@@ -77,7 +77,9 @@ func localISOPath(u *url.URL) string {
  return u.String()
  }
 
- return filepath.Join(detect.ISOCacheDir(), path.Base(u.Path))
+ name := base64.URLEncoding.EncodeToString([]byte(u.String()))
+
+ return filepath.Join(detect.ISOCacheDir(), name)
 }
 
 // ISO downloads and returns the path to the downloaded ISO