-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump govulncheck version to 1.1.0 #124752
base: master
Are you sure you want to change the base?
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/sig testing |
LGTM label has been added. Git tree hash: c179c07573f84ef17f94fdddcc311b9bcc0b37f7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArkaSaha30, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
3 similar comments
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
/hold |
|
eedb7a2
to
0434a71
Compare
0434a71
to
3d8db78
Compare
This commit will bump govulncheck version 1.0.1 -> 1.1.0 Additionally, handle govulncheck exit code returned It will handle the govulncheck exit code returned which returning 3 instead of 0 with the new v1.1.0 by adding `|| true` so that the verify job does not fail but logs the go vulnerability found. Signed-off-by: ArkaSaha30 <[email protected]>
3a57ed0
to
2e0ce79
Compare
/lgtm |
LGTM label has been added. Git tree hash: d1c064e2b0f0522833d2dc9047dfd88e3eea6de2
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This commit will bump govulncheck version from 1.0.1 -> 1.1.0
Which issue(s) this PR fixes:
Fixes # kubernetes/sig-security#95
Special notes for your reviewer:
We might need to backport this bump to 1.30 and 1.29 release branches.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: