gce: refactor regional/global GCE API methods #16367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
upodroid
force-pushed
the
support-regional-resources
branch
from
ffdaa21
to
8d9834f
Compare
k8s-ci-robot
added
size/XL
|
/test pull-kops-e2e-k8s-gce-cilium |
upodroid
force-pushed
the
support-regional-resources
branch
from
8d9834f
to
4d4e6e8
Compare
upodroid
force-pushed
the
support-regional-resources
branch
from
4d4e6e8
to
a296539
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google splits some services in to regional vs global with identical object types. I fixed the methods to detect if a region is being supplied.
Required for:
Also, we don't have an e2e test for gce internal only clusters :( bit tricky to set one up.
/cc @justinsb @hakman