Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write log when marking InstanceGroup node as needs update #16079

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/cloudinstances/cloud_instance_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ func (group *CloudInstanceGroup) AdjustNeedUpdate() {
if makeNotReady {
group.NeedUpdate = append(group.NeedUpdate, member)
member.Status = CloudInstanceStatusNeedsUpdate
fmt.Printf("InstanceGroup %s node %s has needs-update annotation\n", group.HumanName, member.Node.Name)
} else {
newReady = append(newReady, member)
}
Expand Down
2 changes: 2 additions & 0 deletions upup/pkg/fi/cloudup/awsup/aws_cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,7 @@ func buildKarpenterGroup(c AWSCloud, cluster *kops.Cluster, ig *kops.InstanceGro
status = cloudinstances.CloudInstanceStatusUpToDate
} else {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
fmt.Printf("InstanceGroup %s node %s launch configuration is behind\n", karpenterGroup.HumanName, id)
}
cloudInstance, _ := karpenterGroup.NewCloudInstance(id, status, nodeMap[id])
addCloudInstanceData(cloudInstance, instance)
Expand Down Expand Up @@ -1256,6 +1257,7 @@ func buildCloudInstance(i *autoscaling.Instance, instances map[string]*ec2.Insta
status := cloudinstances.CloudInstanceStatusUpToDate
if newConfigName != currentConfigName {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
fmt.Printf("InstanceGroup %s node %s launch configuration is behind\n", cg.HumanName, id)
}
cm, err := cg.NewCloudInstance(id, status, nodeMap[id])
if err != nil {
Expand Down
2 changes: 2 additions & 0 deletions upup/pkg/fi/cloudup/gce/instancegroups.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,10 @@ func getCloudGroups(c GCECloud, cluster *kops.Cluster, instancegroups []*kops.In

if i.Version != nil && latestInstanceTemplate == i.Version.InstanceTemplate {
g.Ready = append(g.Ready, cm)
fmt.Printf("InstanceGroup %s nodes launch templates are NOT behind\n", cm.CloudInstanceGroup.HumanName)
} else {
g.NeedUpdate = append(g.NeedUpdate, cm)
fmt.Printf("InstanceGroup %s nodes launch templates are behind\n", cm.CloudInstanceGroup.HumanName)
}
}

Expand Down
1 change: 1 addition & 0 deletions upup/pkg/fi/cloudup/hetzner/cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ func buildCloudInstanceGroup(ig *kops.InstanceGroup, sg []*hcloud.Server, nodeMa
status := cloudinstances.CloudInstanceStatusUpToDate
if _, ok := server.Labels[TagKubernetesInstanceNeedsUpdate]; ok {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
fmt.Printf("InstanceGroup %s node %s has %s label\n", cloudInstanceGroup.HumanName, server.Name, server.Labels[TagKubernetesInstanceNeedsUpdate])
}

id := strconv.Itoa(server.ID)
Expand Down
1 change: 1 addition & 0 deletions upup/pkg/fi/cloudup/openstack/server_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ func osBuildCloudInstanceGroup(c OpenstackCloud, cluster *kops.Cluster, ig *kops
status := cloudinstances.CloudInstanceStatusUpToDate
if generationName != observedName || instance.Status == errorStatus {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
fmt.Printf("InstanceGroup %s instance %s generationName and observedName mismatch or instance in error\n", cg.HumanName, instance.ID)
}
cm, err := cg.NewCloudInstance(instance.ID, status, nodeMap[instance.ID])
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions upup/pkg/fi/cloudup/scaleway/cloud.go
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,7 @@ func buildCloudGroup(s *scwCloudImplementation, ig *kops.InstanceGroup, sg []*in
for _, tag := range server.Tags {
if tag == TagNeedsUpdate {
status = cloudinstances.CloudInstanceStatusNeedsUpdate
fmt.Printf("InstanceGroup %s node %s has tag %s\n", cloudInstanceGroup.HumanName, server.Name, tag)
}
}
cloudInstance, err := cloudInstanceGroup.NewCloudInstance(server.ID, status, nodeMap[server.ID])
Expand Down