Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Put control-plane and apiserver nodes in IPv6-only subnets #15986

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP Put control-plane and apiserver nodes in IPv6-only subnets #15986

wants to merge 2 commits into from

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Oct 3, 2023 •
edited

AWS now supports IPv6 instance targets, which means we can stop using DualStack subnets for the control plane, APIServer nodes, and bastion hosts.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2023
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-k8s-aws-calico-ipv6

@k8s-ci-robot
Copy link
Contributor

@johngmyers: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test presubmit-kops-aws-boskos
  • /test presubmit-kops-aws-boskos-kubetest2
  • /test presubmit-kops-aws-scale-amazonvpc
  • /test presubmit-kops-aws-scale-amazonvpc-using-cl2
  • /test presubmit-kops-aws-small-scale-amazonvpc-using-cl2
  • /test pull-kops-aws-distro-al2023
  • /test pull-kops-aws-distro-amazonlinux2
  • /test pull-kops-aws-distro-debian10
  • /test pull-kops-aws-distro-debian11
  • /test pull-kops-aws-distro-debian12
  • /test pull-kops-aws-distro-flatcar
  • /test pull-kops-aws-distro-rhel8
  • /test pull-kops-aws-distro-rhel9
  • /test pull-kops-aws-distro-rocky8
  • /test pull-kops-aws-distro-ubuntu2004
  • /test pull-kops-aws-distro-ubuntu2004arm64
  • /test pull-kops-aws-distro-ubuntu2204
  • /test pull-kops-aws-distro-ubuntu2204arm64
  • /test pull-kops-build
  • /test pull-kops-e2e-addon-resource-tracking
  • /test pull-kops-e2e-arm64
  • /test pull-kops-e2e-aws-apiserver-nodes
  • /test pull-kops-e2e-aws-cloud-controller-manager
  • /test pull-kops-e2e-aws-dns-none
  • /test pull-kops-e2e-aws-external-dns
  • /test pull-kops-e2e-aws-ipv6-external-dns
  • /test pull-kops-e2e-aws-ipv6-karpenter
  • /test pull-kops-e2e-aws-ipv6-terraform
  • /test pull-kops-e2e-aws-karpenter
  • /test pull-kops-e2e-aws-load-balancer-controller
  • /test pull-kops-e2e-aws-nlb
  • /test pull-kops-e2e-aws-node-local-dns
  • /test pull-kops-e2e-aws-terraform
  • /test pull-kops-e2e-cni-calico
  • /test pull-kops-e2e-cni-calico-ipv6
  • /test pull-kops-e2e-cni-canal
  • /test pull-kops-e2e-cni-cilium
  • /test pull-kops-e2e-cni-cilium-eni
  • /test pull-kops-e2e-cni-cilium-etcd
  • /test pull-kops-e2e-cni-cilium-ipv6
  • /test pull-kops-e2e-cni-flannel
  • /test pull-kops-e2e-gce-dns-none
  • /test pull-kops-e2e-k8s-aws-calico
  • /test pull-kops-e2e-k8s-ci
  • /test pull-kops-e2e-k8s-ci-ha
  • /test pull-kops-e2e-k8s-gce-calico-u2004-k22-containerd
  • /test pull-kops-e2e-k8s-gce-ci
  • /test pull-kops-e2e-k8s-gce-cilium
  • /test pull-kops-e2e-k8s-gce-cilium-etcd
  • /test pull-kops-e2e-k8s-gce-ipalias
  • /test pull-kops-e2e-k8s-gce-long-cluster-name
  • /test pull-kops-e2e-kubernetes-do-dns-none
  • /test pull-kops-e2e-kubernetes-do-fqdn
  • /test pull-kops-e2e-kubernetes-do-gossip
  • /test pull-kops-e2e-metrics-server
  • /test pull-kops-e2e-pod-identity-webhook
  • /test pull-kops-kubernetes-e2e-cos-gce
  • /test pull-kops-kubernetes-e2e-cos-gce-serial
  • /test pull-kops-kubernetes-e2e-cos-gce-slow
  • /test pull-kops-latest-e2e-aws-k8s-1-24
  • /test pull-kops-test
  • /test pull-kops-verify-boilerplate
  • /test pull-kops-verify-generated
  • /test pull-kops-verify-gofmt
  • /test pull-kops-verify-golangci-lint
  • /test pull-kops-verify-gomod
  • /test pull-kops-verify-govet
  • /test pull-kops-verify-hashes
  • /test pull-kops-verify-terraform

The following commands are available to trigger optional jobs:

  • /test pull-kops-e2e-aws-upgrade-k124-ko124-to-k125-kolatest
  • /test pull-kops-e2e-aws-upgrade-k125-kolatest-to-k126-kolatest
  • /test pull-kops-e2e-aws-upgrade-k127-ko127-to-k128-kolatest-karpenter
  • /test pull-kops-e2e-aws-upgrade-k127-ko127-to-klatest-kolatest-many-addons
  • /test pull-kops-e2e-cni-amazonvpc
  • /test pull-kops-e2e-cni-amazonvpc-ipv6
  • /test pull-kops-e2e-cni-kuberouter

Use /test all to run the following jobs that were automatically triggered:

  • pull-kops-build
  • pull-kops-e2e-k8s-aws-calico
  • pull-kops-e2e-k8s-gce-cilium
  • pull-kops-e2e-k8s-gce-ipalias
  • pull-kops-test
  • pull-kops-verify-boilerplate
  • pull-kops-verify-generated
  • pull-kops-verify-gofmt
  • pull-kops-verify-golangci-lint
  • pull-kops-verify-gomod
  • pull-kops-verify-govet

In response to this:

/test pull-kops-e2e-k8s-aws-calico-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from johngmyers. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-calico-ipv6

@k8s-ci-robot k8s-ci-robot added area/api area/provider/aws Issues or PRs related to aws provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2023
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-calico-ipv6

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2023
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-calico-ipv6

@johngmyers
Copy link
Member Author

johngmyers commented Oct 3, 2023 •
edited

IPv6 instance targets need to have a primary IPv6 address. Unfortunately, the Terraform AWS provider doesn't support setting the necessary field in the launch template. Filed hashicorp/terraform-provider-aws#33733.

@johngmyers
Copy link
Member Author

Status: instances are registering as targets, but are failing health checks.

@johngmyers
Copy link
Member Author

The issue is that the protocol conversion from IPv4 to IPv6 is causing the traffic between LB and backend to not match any security group rule.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 7, 2023
@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-calico-ipv6

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-cni-calico-ipv6

@johngmyers
Copy link
Member Author

/test pull-kops-e2e-aws-ipv6-terraform

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2023
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2023
@k8s-ci-robot
Copy link
Contributor

@johngmyers: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-ipv6-terraform c4c8a40 link true /test pull-kops-e2e-aws-ipv6-terraform
pull-kops-kubernetes-e2e-ubuntu-gce-build ab4df0f link true /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees
No one assigned
Labels
area/api area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @k8s-ci-robot @k8s-triage-robot