-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: prune dns-controller #15643
base: master
Are you sure you want to change the base?
WIP: prune dns-controller #15643
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Couldn't one start with gossip plus external-dns? |
I can't find validation preventing gossip + external-dns, but external-dns doesn't have gossip configuration support. |
Still, switching from external-dns to none should probably uninstall external-dns. |
Okay, this is confusing. There's |
DNSTypeNone means no DNS work at all. Anyone that wants to use external DNS is free to deploy it on its own. |
@justinsb fyi: in case of AWS there is some downtime: In case of AWS the nodes will lose its connection to control plane. OpenStack migration is almost working: I have executed gossip -> dns none to about 100+ openstack clusters. The only problem that I saw was that kops-controller goes to crashloopbackoff and that will block the rolling-update. The solution for that was that I just terminated the instance where that was located and when new controlplane instance started the problem was gone. Sometimes it happened after first control plane instance update, sometimes after 2 control plane instance updates and sometimes it was working. So it was kind of random when it went through. |
37b168e
to
47f36f9
Compare
@justinsb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
When switching from gossip to dns=none, the rolling-update fails because the dns-controller addon is still present (because it isn't removed, as we never merged #13962). However, the configuration for the dns-controller addon still assumes gossip is running on protokube (which it isn't).
WIP because there are a few ways to tackle this: we could implement addon removal (but I would rather we did it very carefully, perhaps with explicit removal). We could simply keep dns-controller but not install it. Or we could do what we do here - install a different (empty) manifest.