Skip to content

Commit

Permalink
feat: nodeup will only check the nodeupConfigHash if it is provided
Browse files Browse the repository at this point in the history
On bare metal, the nodeupConfig is harder to predict and we will have
to use other ways to trigger an update anyway.
  • Loading branch information
justinsb committed Dec 1, 2023
1 parent 9bacfdd commit 53d59a8
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions upup/pkg/fi/nodeup/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,10 @@ func (c *NodeUpCommand) Run(out io.Writer) error {
return fmt.Errorf("no instance group defined in nodeup config")
}

if want, got := bootConfig.NodeupConfigHash, base64.StdEncoding.EncodeToString(nodeupConfigHash[:]); got != want {
return fmt.Errorf("nodeup config hash mismatch (was %q, expected %q)", got, want)
if want := bootConfig.NodeupConfigHash; want != "" {
if got := base64.StdEncoding.EncodeToString(nodeupConfigHash[:]); got != want {
return fmt.Errorf("nodeup config hash mismatch (was %q, expected %q)", got, want)
}
}

err = evaluateSpec(&nodeupConfig, bootConfig.CloudProvider)
Expand Down

0 comments on commit 53d59a8

Please sign in to comment.