Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "next steps" after kompose convert #345

Open
concaf opened this issue Dec 27, 2016 · 4 comments
Open

Show "next steps" after kompose convert #345

concaf opened this issue Dec 27, 2016 · 4 comments
Labels
kind/discuss lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@concaf
Copy link
Contributor

concaf commented Dec 27, 2016

It would be great if we output a message relaying the "what next" information after kompose convert is run.

For e.g.

  • If a pvc object is created, we should display something like "you need to have a pv ready to use this object"
  • In case of a missing port, "you might want to expose this service manually since kompose could not detect a port"

Thoughts?
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 3, 2017
@surajnarwade
Added warning after PVC creation
c37831c 
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 3, 2017
@surajnarwade
Added warning after PVC creation
2882376 
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 4, 2017
@surajnarwade
Added warning after PVC creation
0760390 
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 4, 2017
@surajnarwade
Added warning after PVC creation
aa30acc 
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 13, 2017
@surajnarwade
Added warning after PVC creation
9a6c1d9 
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
qujinping pushed a commit to qujinping/kompose that referenced this issue Apr 25, 2017
@surajnarwade
Added warning after PVC creation
5c1a4ee 
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
cdrage pushed a commit to cdrage/kompose that referenced this issue May 17, 2017
@surajnarwade @cdrage
Added warning after PVC creation
f88d489 
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
@cdrage
Copy link
Member

cdrage commented Jul 19, 2017

I agree with this, @surajnarwade has updated this in cdrage@f88d489 however, I still think there could be some improvement.

Tools such as Helm have a lot of logging output that describes all the steps after launching / using Helm.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2018
@cdrage
Copy link
Member

cdrage commented Jan 2, 2018

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 2, 2018
@cdrage
Copy link
Member

cdrage commented Nov 21, 2022

Yeah.... we REALLY need to improve this.

My suggestion is that we add some details on what needs to be done (as explained above) such as:

  • Explain pv is required
  • Explain what HAS been done
  • Change output to a better way [NOT CONVERTED] - depends_on for example. for parts of compose we aren't able to convert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/discuss lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pradeepto @cdrage @concaf @k8s-ci-robot @fejta-bot