Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add restart option for DaemonSets & StatefulSets #9866

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

avanish23
Copy link
Contributor

This PR attempts to allow users to restart the DaemonSets & StatefulSets from the Dashboard itself.
Currently, only Deployments are restartable from the dashboard.
Closes #6404

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2025
Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2025
@floreks floreks added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 30, 2025
@floreks floreks changed the title Restart option for DaemonSets & StatefulSets feat: restart option for DaemonSets & StatefulSets Jan 30, 2025
@floreks floreks changed the title feat: restart option for DaemonSets & StatefulSets feat: add restart option for DaemonSets & StatefulSets Jan 30, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025
@maciaszczykm
Copy link
Member

/approve

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 26.47059% with 50 lines in your changes missing coverage. Please review.

Project coverage is 35.81%. Comparing base (31f5d62) to head (6ff2baf).
Report is 45 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9866      +/-   ##
==========================================
- Coverage   35.88%   35.81%   -0.07%     
==========================================
  Files         301      303       +2     
  Lines       14503    14566      +63     
  Branches      202      202              
==========================================
+ Hits         5204     5217      +13     
+ Misses       9075     9072       -3     
- Partials      224      277      +53     

@floreks
Copy link
Member

floreks commented Feb 3, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avanish23, floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit db6e1ee into kubernetes:master Feb 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart option for DaemonSets
4 participants