-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refresh development container #8828
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8828 +/- ##
=======================================
Coverage 37.19% 37.20%
=======================================
Files 255 255
Lines 11156 11149 -7
Branches 157 158 +1
=======================================
- Hits 4150 4148 -2
- Misses 6756 6790 +34
+ Partials 250 211 -39 |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
@maciaszczykm @floreks PTAL Thanks! |
|
/checkcla |
/easycla |
@floreks @maciaszczykm dashboard runs properly with this development container.
|
aceaee5
to
6ef615e
Compare
What I meant is that running |
The development container provides developers with a clean environment at all time. This creates a environment for static check, test, build and execute dashboard on local machine that is almost the same as CI/CD environment.
Also, stop using KIND_EXPERIMENTAL_DOCKER_NETWORK.
bbee95e
to
b7540d7
Compare
@floreks could you check this again? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@floreks could you check this again? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Support for new Kubernetes Dashboard configuration.
Omitted connecting to an external K8s cluster.
Currently, it only supports kind k8s clusters built by scripts in this repository.