Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sig-etcd lead emails to sigs.yaml #8160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add sig-etcd lead emails to sigs.yaml #8160

wants to merge 1 commit into from
+5 −0

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Nov 20, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2024
@jmhbnz
Copy link
Member Author

jmhbnz commented Nov 20, 2024

/hold
Hold for ack from @serathius, @ahrtr and @wenjiaswe that emails proposed are correct/preferred (I've taken them from our existing OWNERS file).

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
BenTheElder
BenTheElder approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
Thank you!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2024
@ahrtr
Copy link
Member

ahrtr commented Nov 21, 2024

/lgtm
/approve

Thanks @jmhbnz

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, BenTheElder, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@pohly pohly Awaiting requested review from pohly

Assignees

@BenTheElder BenTheElder

@serathius serathius

@ahrtr ahrtr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmhbnz @ahrtr @k8s-ci-robot @serathius @BenTheElder