Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of Elections subproject #6720

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Creation of Elections subproject #6720

merged 1 commit into from
Jul 11, 2022

Conversation

jberkus
Copy link
Contributor

@jberkus jberkus commented Jun 24, 2022

Creation of the subproject and initial file reorganization.

Moves all elections files under top-level /elections folder
Adds READMEs for the subproject duties
Adds initial subproject members

This does need to be finished as a prerequisite to the 2022 SC election. Stuff that we need to finish this PR:

  • Approve all new processes/ownership introduced
  • Finalize initial list of subproject members/approvers
  • Do build on sigs.yaml

IMPORTANT: the elections app will need to be upgraded in coordination with this file location change. As such, it should not be merged except as a coordinated activity.
/hold

This will be the first of several large PRs to organize elections. Additional work that needs to be done, including:

  • Extracting all documentation from the individual election directories and consolidating it into some kind of sensible structure.
  • Provide template election files
  • Build out more detailed processes for undocumented things like picking EOs.

/sig contributor-experience
/area elections

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. area/elections Issues or PRs related to community elections cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@jberkus
Copy link
Contributor Author

jberkus commented Jun 24, 2022

oh, yeah:

Fixes #6084

@jberkus
Copy link
Contributor Author

jberkus commented Jun 25, 2022

/assign @mrbobbytables @nikhita @cblecker

@jberkus jberkus mentioned this pull request Jul 5, 2022
Merged
@jberkus
Copy link
Contributor Author

jberkus commented Jul 6, 2022

Would like feedback on content from our TLs (and other people) before I fix test issues and build sigs.yaml, thanks!

detiber
detiber reviewed Jul 7, 2022
View reviewed changes
elections/README.md Outdated Show resolved Hide resolved
mrbobbytables
mrbobbytables reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jberkus just a few non-blocking comments and potential follow up items after this is merged. 👍

elections/README.md Outdated Show resolved Hide resolved
elections/README.md Outdated Show resolved Hide resolved
elections/README.md Outdated Show resolved Hide resolved
elections/teams/README.md Show resolved Hide resolved
@jberkus
Creation of Elections subproject
7ec56a1 
and initial file reorganization.

Moves all elections files under top-level /elections folder
Adds READMEs for the subproject duties
Adds initial subproject members

Signed-off-by: Josh Berkus <[email protected]>
@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Jul 8, 2022
@jberkus
Copy link
Contributor Author

jberkus commented Jul 8, 2022

All feedback addressed, sigs updated.

@cblecker @nikhita please approve, thanks!

@cblecker cblecker changed the title WIP: Creation of Elections subproject Creation of Elections subproject Jul 8, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2022
@cblecker
Copy link
Member

cblecker commented Jul 8, 2022

/approve
Wearing my ContribEx TL hat

mrbobbytables
mrbobbytables approved these changes Jul 9, 2022
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @jberkus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2022
nikhita
nikhita approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @jberkus!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, jberkus, mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cblecker,jberkus,mrbobbytables,nikhita]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrbobbytables
Copy link
Member

We have approval from the two TLs, should be good enough to merge :) @jberkus please release the hold when you're ready

@jberkus
Copy link
Contributor Author

jberkus commented Jul 11, 2022

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 07908c0 into kubernetes:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@nikhita nikhita nikhita approved these changes

@mrbobbytables mrbobbytables mrbobbytables approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@cblecker cblecker

@mrbobbytables mrbobbytables

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/elections Issues or PRs related to community elections cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jberkus @cblecker @k8s-ci-robot @mrbobbytables @detiber @nikhita