Add two test cases for OCCM #2614

dd-georgiev · 2024-06-03T07:11:34Z

What this PR does / why we need it:
I added test cases for testing:

The preservation of floating IPs when the loadbalancer.openstack.org/keep-floatingip: "true" annotation is added to service
Basic checks for healthmonitors created via service annotations.

k8s-ci-robot · 2024-06-03T07:11:36Z

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

linux-foundation-easycla · 2024-06-03T07:11:38Z

The committers listed above are authorized under a signed CLA.

✅ login: dd-georgiev (5ca04df, 823e5dd)
✅ login: NymanRobin / name: Robin Nyman (84436a2)

k8s-ci-robot · 2024-06-03T07:11:43Z

Hi @dd-georgiev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dulek

/ok-to-test

Looks like you need to solve EasyCLA here.

dulek · 2024-06-06T10:04:30Z

tests/e2e/cloudprovider/test-lb-service.sh

+	kubectl -n $NAMESPACE delete service ${service}
+
+	printf "\n>>>>>>> Checking if Floating IP is still in openstack"
+	FIP_IN_OS=`openstack floating ip list --floating-ip-address "$FIP" -f json | jq length`


Same here, plus I'd rather rely on ID here to double-check if IP wasn't deleted and recreated.

dulek · 2024-06-06T10:04:58Z

tests/e2e/cloudprovider/test-lb-service.sh

+	printf "\n>>>>>>> Getting the floating IP of the service\n"
+	FIP=`kubectl -n $NAMESPACE get svc test-preserve-fip --no-headers| awk '{print $4}'`
+	printf "\n>>>>>>> Checking if Floating IP is in openstack"
+	FIP_IN_OS=`openstack floating ip list --floating-ip-address "$FIP" -f json | jq length`


openstack floating ip show and checking return code?

dulek · 2024-06-06T10:08:00Z

tests/e2e/cloudprovider/test-lb-service.sh

+	wait_for_service_address ${service}
+	printf "\n>>>>>>> Checking if Octavia health monitor is matching spec\n"
+
+	HM_ID=`openstack loadbalancer healthmonitor list | grep "$service" | awk '{print $2}'`


You could do show with an exact expected name. That could be useful if we'll add new tests with healthmonitors later.

dd-georgiev · 2024-06-06T12:06:19Z

/ok-to-test

Looks like you need to solve EasyCLA here.

Interesting, I signed the document (in docusign) multiple times but it still doesn't show up here.

dulek · 2024-06-06T15:16:02Z

/easycla

Let's retry. You can also try checking the troubleshooting page. E.g. I had issues, because I was sending commits signed with a different email than the one I had in GitHub.

dulek · 2024-06-06T15:17:09Z

/test pull-cloud-provider-openstack-check

This one's stuck.

jichenjc · 2024-06-07T02:09:05Z

/easycla

jichenjc · 2024-06-07T02:09:11Z

/lgtm

k8s-ci-robot · 2024-06-18T10:21:45Z

New changes are detected. LGTM label has been removed.

k8s-triage-robot · 2024-09-16T11:19:35Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

kayrus · 2024-11-15T11:20:45Z

@dd-georgiev your PR contains commits from two accounts: @dd-georgiev and @d-dimitrov-georgiev. You should either squash the commits into one if you are the only author, or sign the CLA under the @d-dimitrov-georgiev account.

k8s-ci-robot · 2025-02-10T06:11:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…h monitors Added two test cases for preserving floating ip and for testing health monitors

If the initial formatting and mounting fails in NodeStageVolume try to rescan the device and retry the operation. This prevents failures if the device information is reported wrongly which would otherwise be blocking the mounting. Signed-off-by: NymanRobin <[email protected]> Fixed merge conflicts Rebasing: Rebasing

k8s-ci-robot · 2025-02-10T17:03:02Z

@dd-georgiev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
openstack-cloud-csi-manila-sanity-test	`1ba7852`	link	true	`/test openstack-cloud-csi-manila-sanity-test`
pull-cloud-provider-openstack-check	`84436a2`	link	true	`/test pull-cloud-provider-openstack-check`
openstack-cloud-controller-manager-ovn-e2e-test	`84436a2`	link	true	`/test openstack-cloud-controller-manager-ovn-e2e-test`
openstack-cloud-controller-manager-e2e-test	`84436a2`	link	true	`/test openstack-cloud-controller-manager-e2e-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dd-georgiev · 2025-02-10T17:47:07Z

@kayrus sorry for the substantial delay.

I'm not sure why the tests are failing. Two of them are because of:
error: 'Access denied for user 'root'@'localhost' (using password: NO)'

Can you advice for further actions?

k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 3, 2024

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 3, 2024

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2024

k8s-ci-robot requested review from jichenjc and mdbooth June 3, 2024 07:11

dulek reviewed Jun 6, 2024

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2024

k8s-ci-robot assigned jichenjc Jun 7, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024

k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 16, 2024

dd-georgiev force-pushed the ccm_tests branch from eae345a to bb2cb34 Compare February 10, 2025 06:11

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 10, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2025

dd-georgiev added 2 commits February 10, 2025 08:14

Added two test cases for preserving floating ip and for testing healt…

823e5dd

…h monitors Added two test cases for preserving floating ip and for testing health monitors

Resolved merge conflicts

5ca04df

dd-georgiev force-pushed the ccm_tests branch from bb2cb34 to 1ba7852 Compare February 10, 2025 06:29

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2025

dd-georgiev force-pushed the ccm_tests branch from 1ba7852 to 4b509dc Compare February 10, 2025 16:38

dd-georgiev force-pushed the ccm_tests branch 2 times, most recently from e55d1fb to 84436a2 Compare February 10, 2025 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add two test cases for OCCM #2614

Add two test cases for OCCM #2614

dd-georgiev commented Jun 3, 2024

k8s-ci-robot commented Jun 3, 2024

linux-foundation-easycla bot commented Jun 3, 2024 •

edited

Loading

k8s-ci-robot commented Jun 3, 2024

dulek left a comment

dulek Jun 6, 2024

dulek Jun 6, 2024

dulek Jun 6, 2024

dd-georgiev commented Jun 6, 2024

dulek commented Jun 6, 2024

dulek commented Jun 6, 2024

jichenjc commented Jun 7, 2024

jichenjc commented Jun 7, 2024

k8s-ci-robot commented Jun 18, 2024

k8s-triage-robot commented Sep 16, 2024

kayrus commented Nov 15, 2024

k8s-ci-robot commented Feb 10, 2025

k8s-ci-robot commented Feb 10, 2025

dd-georgiev commented Feb 10, 2025

Add two test cases for OCCM #2614

Are you sure you want to change the base?

Add two test cases for OCCM #2614

Conversation

dd-georgiev commented Jun 3, 2024

k8s-ci-robot commented Jun 3, 2024

linux-foundation-easycla bot commented Jun 3, 2024 • edited Loading

k8s-ci-robot commented Jun 3, 2024

dulek left a comment

Choose a reason for hiding this comment

dulek Jun 6, 2024

Choose a reason for hiding this comment

dulek Jun 6, 2024

Choose a reason for hiding this comment

dulek Jun 6, 2024

Choose a reason for hiding this comment

dd-georgiev commented Jun 6, 2024

dulek commented Jun 6, 2024

dulek commented Jun 6, 2024

jichenjc commented Jun 7, 2024

jichenjc commented Jun 7, 2024

k8s-ci-robot commented Jun 18, 2024

k8s-triage-robot commented Sep 16, 2024

kayrus commented Nov 15, 2024

k8s-ci-robot commented Feb 10, 2025

k8s-ci-robot commented Feb 10, 2025

dd-georgiev commented Feb 10, 2025

linux-foundation-easycla bot commented Jun 3, 2024 •

edited

Loading