-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(occm): Empty nodeSelector by default #2586
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: babykart <[email protected]>
Welcome @babykart! |
Hi @babykart. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: babykart <[email protected]>
@@ -46,9 +46,10 @@ livenessProbe: {} | |||
# Set readinessProbe in the same way like livenessProbe | |||
readinessProbe: {} | |||
|
|||
# Set nodeSelector where the controller should run, i.e. controlplane nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could still override the values using helm, no matter what is defined in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you increase the version number in https://github.com/kubernetes/cloud-provider-openstack/blob/master/charts/openstack-cloud-controller-manager/Chart.yaml#L7 otherwise the linter will fail
/ok-to-test |
Signed-off-by: babykart <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@wwentland introduced this in #2346. Why do we want to change the default again? It's possible to override this, as I indicated on the issue itself and I believe CPO is a control plane service anyway. We're also following cloud-provider-aws pattern with this: https://github.com/kubernetes/cloud-provider-aws/blob/master/charts/aws-cloud-controller-manager/values.yaml#L14-L16 This is changing a default behavior, so we can't merge this without a release note. But that being said I'm still opposed to this. /hold for release note. |
yeah actually @dulek had quite good point. /approve cancel |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #2550
Special notes for reviewers:
Release note: