-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] - add annotation for custom octavia listener tags #2580
base: master
Are you sure you want to change the base?
Conversation
…or load balancer and listener tags. Added documentation about new annotation Co-authored-by: KingDaemonX <[email protected]>
The committers listed above are authorized under a signed CLA. |
Welcome @dd-georgiev! |
Hi @dd-georgiev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Okay, so this needs a release note announcing the feature, that's for sure. |
I've converted this into draft. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Added support for new annotation which provides the ability to add tags when the load balancer is created. Those tags affect the load balancer and the listener. The rest of the resources are not tagged
What this PR does / why we need it:
#2327
Special notes for reviewers:
But I don't think this will impact us, since "," is used to split the tags. Hence tag containing "," cannot exist. I didn't document this behavior as it fells like common sense. Also the docs are coming from the Mitaka project.
4. I'm not sure if this change is big enough for release notes, but I can add them if necessary
Release note: