-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] improve LB logic maintainability #2377
Conversation
Skipping CI for Draft Pull Request. |
Oh my. Please put updating the license header into a separate PR, this one will be hard enough to review already. |
@kayrus |
@pierreprinetti My goal was to split |
/hold |
Why? That being said, the copyright year is not very interesting from a legal perspective, because the date of publication is also kept by Github. So you could probably put bananas in it. |
@pierreprinetti I've seen such updates in other opensource projects. If you think that this doesn't make sense, then I'll put this year to the new files and skip others. |
244f696
to
d81466a
Compare
d81466a
to
e06ddf5
Compare
/test openstack-cloud-controller-manager-e2e-test |
/test openstack-cloud-controller-manager-e2e-test |
1 similar comment
/test openstack-cloud-controller-manager-e2e-test |
@kayrus: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ca6ad90
to
617f2ee
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kayrus: Hi! Do we have another attempt at merging this? I believe it's a very good idea to split this code into separate files. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR improves the loadbalancer code readability and maintainability.
Which issue this PR fixes(if applicable):
fixes #2374
Special notes for reviewers:
Release note: