Update RBAC and sync interval for storageQuotaPeriodicSync in cns-csi.yaml #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/approve |
1 similar comment
|
/approve |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akankshapanse, deepakkinni, nikhilbarge, vdkotkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This MR adds RBAC for storagequotaperiodicsync CR in cns-csi.yaml for WCP version 1.28-1.30, with sync interval time updated to 10 min.
This also adds minor changes under #3081
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
Tested fix on the setup where syncer was crashing due to missing RBAC, and later pods came to running state
Before fix :
root@422a5584452ed95937062cf0861b089a [ ~ ]# k get pods -n vmware-system-csi
NAME READY STATUS RESTARTS AGE
vsphere-csi-controller-75858f4bf4-7xrgk 6/7 CrashLoopBackOff 205 (2m38s ago) 13h
vsphere-csi-controller-75858f4bf4-pv5kz 7/7 Running 228 (5m25s ago) 13h
vsphere-csi-webhook-578d97774b-t9q86 1/1 Running 1 (13h ago) 13h
vsphere-csi-webhook-578d97774b-zv5v2 1/1 Running 0 13h
After fix :
root@422a5584452ed95937062cf0861b089a [ ~ ]# k get pods -n vmware-system-csi
NAME READY STATUS RESTARTS AGE
vsphere-csi-controller-75858f4bf4-2gslq 7/7 Running 0 14m
vsphere-csi-controller-75858f4bf4-jfh7f 7/7 Running 0 14m
vsphere-csi-webhook-578d97774b-t9q86 1/1 Running 1 (13h ago) 13h
vsphere-csi-webhook-578d97774b-zv5v2 1/1 Running 0 13h
root@422a5584452ed95937062cf0861b089a [ ~ ]#
Special notes for your reviewer:
Release note: