Increase probe-timeout to avoid CrashloopBackoff

[sathieu]

Also ensure probe-timeout of the liveness-probe container is shorter than livenessProbe of the vsphere-csi-node container (5s)

What this PR does / why we need it:

Without this, if the socket probe takes too long, another livenessProbe check is started while the previous is not finished. Liveness probe requests pile up until the container liveness-probe failed in CrashLoopBackoff

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

Yes (deployed since a few months)

Special notes for your reviewer:

Release note:

Increase probe-timeout to avoid CrashloopBackoff

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sathieu
Once this PR has been reviewed and has the lgtm label, please assign chethanv28 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @sathieu!

It looks like this is your first PR to kubernetes-sigs/vsphere-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/vsphere-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sathieu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sathieu]

Answering @divyenpatel questions at #2931 (review)

@jacen57 do you think this needs to updated in the documentation here - https://github.com/kubernetes-csi/livenessprobe?tab=readme-ov-file#command-line-options

Probably. A lot of drivers override this timeout to at least 3s. See here and here. azure-lustre up to 120s!

Can you update this for other liveness-probe container in the same file? https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/ed4a34ac281bc907825f73466eab5a38a4374c6b/manifests/vanilla/vsphere-csi-driver.yaml#L532C17-L533

Done.

[sathieu]

I created kubernetes-csi/livenessprobe#293 to discuss changing the default:

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sathieu]

this is not stale. Just waiting for review.

[sathieu]

/remove-lifecycle stale