Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update manifest and helm charts for v1.4.8 #1744

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 29, 2025

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from nilekhc and tam7t January 29, 2025 00:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2025
@aramase
Copy link
Member Author

aramase commented Jan 29, 2025

/hold

wait for #1745 to be merged and release to be cut.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@aramase
Copy link
Member Author

aramase commented Jan 29, 2025

/assign @enj

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 29, 2025

@aramase: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-csi-driver-image-scan f5e98d7 link false /test pull-secrets-store-csi-driver-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.50%. Comparing base (87f51ec) to head (f5e98d7).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1744      +/-   ##
==========================================
+ Coverage   35.83%   36.50%   +0.66%     
==========================================
  Files          63       63              
  Lines        3759     4526     +767     
==========================================
+ Hits         1347     1652     +305     
- Misses       2268     2731     +463     
+ Partials      144      143       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enj
Copy link
Contributor

enj commented Jan 29, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2025
@aramase
Copy link
Member Author

aramase commented Jan 29, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3c618c8 into kubernetes-sigs:main Jan 29, 2025
29 of 30 checks passed
@aramase aramase deleted the aramase/r/release_v1.4.8 branch January 29, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants