Fix helm valuesInline merge failure when types differ

[denysvitali]

Warning

All the code was generated by Opus 4.5 - but it's remarkably good!

When using valuesInline with helm charts, kustomize would fail with "wrong node kind" errors when the chart's values.yaml had a different type than what the user provided. For example:

• Chart has topologySpreadConstraints: {} but user provides a list
• Chart has githubConfigSecret: {github_token: ""} but user provides a string

This adds an AllowKindChange option to MergeOptions that allows the source value to completely replace the destination when their YAML node kinds differ (e.g., map vs list, map vs scalar).

The HelmChartInflationGenerator now enables this option when merging values, fixing the regression introduced in kustomize 5.4.0.

Fixes #5766 and actions/actions-runner-controller#3819

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: denysvitali
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: denysvitali / name: Denys Vitali (3a8f63c)

[k8s-ci-robot]

Welcome @denysvitali!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @denysvitali. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[denysvitali]

/retest

[k8s-ci-robot]

@denysvitali: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.