feat: add exec-plugin argument and environment support

[xvzf]

Previously, the documentation lead to think that this is working, but
it's not been implemented.

This PR is fixing this!

I've not seen any test cases for the exec plugins, can you point me to them please?

Signed-off-by: Matthias Riegler [email protected]

[k8s-ci-robot]

Welcome @xvzf!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @xvzf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[koba1t]

@xvzf

We have already decided not to add environment support in kustomize.

• https://kubectl.docs.kubernetes.io/faq/kustomize/eschewedfeatures/#build-time-side-effects-from-cli-args-or-env-variables

We have the list of Eschewed Features that this project will not support. Please check this page before considering requests for any new feature.

If I misunderstood your request, Feel free to open a feature request issue and tell me what you want.

/close

[k8s-ci-robot]

@koba1t: Closed this PR.

In response to this:

@xvzf

We have already decided not to add environment support in kustomize.

• https://kubectl.docs.kubernetes.io/faq/kustomize/eschewedfeatures/#build-time-side-effects-from-cli-args-or-env-variables

We have the list of Eschewed Features that this project will not support. Please check this page before considering requests for any new feature.

If I misunderstood your request, Feel free to open a feature request issue and tell me what you want.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xvzf]

Hey @koba1t this is not adding environment support to kustomize but implement the functionality that's already there for container-based functions.
I'll open an issue later today with some examples

[xvzf]

Hey @koba1t - it took a long time, had to work on other things -- the issue is up now!

[xvzf]

@koba1t is there a way to re-open the PR?

[koba1t]

Currently, I am talking with other maintainers.
Please wait a little more time to make a decision for this feature.

[xvzf]

thanks for the feedback @koba1t!

[koba1t]

/reopen

[k8s-ci-robot]

@koba1t: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xvzf]

will. fix the listing tmrw!

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xvzf]

Hey @koba1t is there anything missing I should add? :)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xvzf]

@varshaprasad96 @koba1t is there any chance this is getting merged? :)

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xvzf]

/remove-lifecycle stale

[koba1t]

Hi @varshaprasad96
Looks like you reviewed this PR. Could you recheck this PR?

[xvzf]

Small ping here @koba1t

[koba1t]

/ok-to-test

[koba1t]

HI @xvzf
So sorry to delay the review.
I'll check this PR!

/assign @koba1t

[koba1t]

Thanks for your contribution!
I believe this function is useful and your code looks good to me!

/lgtm
/approve

I am very sorry to have kept you waiting a long time.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, xvzf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment