-
Notifications
You must be signed in to change notification settings - Fork 464
feat: display flavor assignment attempts in events #7646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mykysha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f7e3e21 to
9a86616
Compare
9a86616 to
8d1776d
Compare
|
This PR records flavor attempts tried, however as flavors get chosen on the first-to-fit basis, it may introduce some misleading results. One example would be that not all flavors are tried, resulting in an incomplete list of the flavors that could be chosen. One potential option would be to disregard attempts that have not been tried for all the requested resources, potentially severely limiting the information returned, but making it more true in the end. |
|
@mykysha please set release note cc @mbobrovskyi @mszadkow @IrvingMg please review |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add information about why some flavors were not chosen in favor of the other to the events at the admission.
Which issue(s) this PR fixes:
Fixes #7137
Special notes for your reviewer:
Does this PR introduce a user-facing change?