Skip to content

Conversation

@mykysha
Copy link
Contributor

@mykysha mykysha commented Nov 13, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add information about why some flavors were not chosen in favor of the other to the events at the admission.

Which issue(s) this PR fixes:

Fixes #7137

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 13, 2025
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8d1776d
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/691f37985b3d6000082c2681

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mykysha
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 13, 2025
@mykysha mykysha force-pushed the feat/flavor-attempts branch from f7e3e21 to 9a86616 Compare November 20, 2025 15:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2025
@mykysha mykysha marked this pull request as ready for review November 20, 2025 15:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2025
@mykysha mykysha force-pushed the feat/flavor-attempts branch from 9a86616 to 8d1776d Compare November 20, 2025 15:45
@mykysha
Copy link
Contributor Author

mykysha commented Nov 20, 2025

This PR records flavor attempts tried, however as flavors get chosen on the first-to-fit basis, it may introduce some misleading results.

One example would be that not all flavors are tried, resulting in an incomplete list of the flavors that could be chosen.
Another, and more serious one, would be that sometimes we might not reach the failure point for one of the flavors attempted, resulting in a message that is falsely marked as "Fit". As an example, in the test "multiple flavors, leader worker set, workers request GPU, leader does not request GPU, fits" in the flavorassigner_test.go there is one flavor that should be Fit, and another that should be NoFit because of the missing GPU resource. In fact, if another two resources get checked first, and then the fitting flavor is chosen on the gpu check, we do not get the missing resource message, hence do not fail the check.

One potential option would be to disregard attempts that have not been tried for all the requested resources, potentially severely limiting the information returned, but making it more true in the end.

@mimowo
Copy link
Contributor

mimowo commented Nov 21, 2025

@mykysha please set release note

cc @mbobrovskyi @mszadkow @IrvingMg please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FlavorFungability: surface to the user why certain flavors where skipped

3 participants